Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation settings should be in project settings #80763

Open
aki-cat opened this issue Aug 18, 2023 · 6 comments · May be fixed by #69012 or #98235
Open

Indentation settings should be in project settings #80763

aki-cat opened this issue Aug 18, 2023 · 6 comments · May be fixed by #69012 or #98235

Comments

@aki-cat
Copy link

aki-cat commented Aug 18, 2023

Godot version

4.1.1-stable

System information

Windows 10, but happens in any system

Issue description

Code indentation settings should be a project setting and not a user editor setting. By default the tab-to-space and space-to-tab auto-change runs and causes issues when two or more people work on the same project with different user settings in their editors.

Since indentation is a project-based choice, it should be in project settings and not the user's settings.

Related to #35007 and #56510

Steps to reproduce

  1. Create a project, write some code that runs in the main scene.
  2. Set your editor settings to use spaces as indentation instead of tabs.
  3. Reindent your code accordingly.
  4. Send your project to someone else (without the .godot folder).
  5. Have them open your project in their editor.
  6. See several code errors due to mismatching indentation.

Minimal reproduction project

N/A

@AThousandShips
Copy link
Member

AThousandShips commented Aug 18, 2023

Thank you for opening an issue

This is proposal territory, not bug territory, we wish to separate the two different things, and this changes things quite a lot, so needs to be tracked as a proposal

Related:

@aki-cat
Copy link
Author

aki-cat commented Aug 18, 2023

I worded it as a proposal, but imo it is a bug because it is a 'expected behaviour' vs 'what really happens' issue. I do understand it is subjective categorizing though, and if y'all maintain that it is a proposal, I can submit it to the proposals page.

@KoBeWi
Copy link
Member

KoBeWi commented Aug 18, 2023

#69012 will resolve this.

@Borges-IST-2003
Copy link

If this is resolved already shouldn't it be closed?
Or can I implement this?

@KoBeWi
Copy link
Member

KoBeWi commented Apr 26, 2024

The pull request I linked is not merged yet.

@marcinn
Copy link
Contributor

marcinn commented Oct 16, 2024

One question. If somebody will set in a project settings text_editor/theme/highlighting/background_color and text_editor/theme/highlighting/text_color to black. Will I be able to override the overridden setting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants