When more than 1 viewport is open, fly mode may incorrectly trigger selection mode change

[bitinn]

Godot version

v4.1.1.stable.official [bd6af8e]

System information

Godot v4.1.1.stable - macOS 13.5.0 - Vulkan (Forward+) - integrated Apple M2 Max - Apple M2 Max (12 Threads)

Issue description

When 2 viewports are open, using fly mode (hold right mouse button, then press QWE keys) in the second viewport will cause all Godot viewports to switch mode. See attached videos.

https://streamable.com/izeh07

Steps to reproduce

Open any 3D scene and navigate it as described.

Minimal reproduction project

N/A as it is pretty trivial to repro, but note sometimes it is only reproduced in the second / third viewport; so my presumption is somehow input are not captured correctly and it triggered both fly mode and selection mode change.

[bitinn]

Note: I did try to repro this on a brand new project and it is semi-consistently reproduced on the 2nd / 3rd viewport, the 1st viewport seems less affected.

[timothyqiu]

I can confirm this.

It seems that capturing the mouse still sends movement events. So whichever viewport covering center point of the screen grabs focus.

[Sauermann]

Conceptually it looks like the QWE-keys are intended to be use for navigating the camera, but fail to set the input event as handled, so they are additionally interpreted for changing the mode.

[ryevdokimov]

Duplicate of: #87639

Which was solved by: #88275

Specifically, by the addition of this (because the title of the PR doesn't suggest anything to do with this issue):

godot/editor/plugins/node_3d_editor_plugin.cpp

Lines 1503 to 1506 in daa81bb

	void Node3DEditorViewport::_surface_mouse_enter() {
	if (Input::get_singleton()->get_mouse_mode() == Input::MOUSE_MODE_CAPTURED) {
	return;
	}