Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling a JavascriptBridge.create_callback() callback from Javascript fails #82734

Closed
adamscott opened this issue Oct 3, 2023 · 0 comments · Fixed by #82736
Closed

Calling a JavascriptBridge.create_callback() callback from Javascript fails #82734

adamscott opened this issue Oct 3, 2023 · 0 comments · Fixed by #82736
Assignees
@adamscott
Labels
bug platform:web regression topic:porting
Milestone
4.2

Comments

@adamscott
Copy link
Member

Godot version

4.2.dev f5696c3

System information

Fedora Workstation 38 - Godot 4.1.beta3 - Vulkan (Forward+)

Issue description

Regression caused by #81105.

Currently, calling GodotJSWrapper.MyProxy(args) without the new keyword returns undefined, which make the following calls fail.

Capture d’écran du 2023-10-03 12-41-27

Capture d’écran du 2023-10-03 12-41-54

Steps to reproduce

  1. Create a callback using JavascriptBridge.create_callback()
  2. Try to call that callback when running a project
  3. See that there's an error when callilng the callback from Javascript

Minimal reproduction project

snippet.zip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamscott adamscott

Labels
bug platform:web regression topic:porting
Projects
None yet
Milestone
4.2
Development

Successfully merging a pull request may close this issue.

Fix godot_js_wrapper_create_cb regression adamscott/godot
1 participant
@adamscott