Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous animation of Polygon2D points no longer works. (Animation Player) #83841

Closed
komdog opened this issue Oct 23, 2023 · 3 comments · Fixed by #84815
Closed

Continuous animation of Polygon2D points no longer works. (Animation Player) #83841

komdog opened this issue Oct 23, 2023 · 3 comments · Fixed by #84815

Comments

@komdog
Copy link

komdog commented Oct 23, 2023

Godot version

v4.2 beta2 [f8818f8]

System information

Windows 11 - v4.2.beta2.official - Compatibility

Issue description

In version 4.2 dev3, I could animate the points of a Polygon 2D in the animation player using the continuous update mode. This no longer works the way it used to. The polygon will remain on the initial frame, no matter how many keyframes are added. I've noticed that when setting the update mode to discrete, the points will still animate but return to the initial shape if no keyframes are present at the current spot in the timeline.

Steps to reproduce

  1. Create a Polygon2D and an Animation player.
  2. Animate two keyframes with different Polygon2D points.
  3. Set the animation update mode to continuous.
  4. See Issue.

Minimal reproduction project

polygon_2d_animation_player_issue.zip

@vyshliy
Copy link

vyshliy commented Oct 23, 2023

Can confirm issue. Also discovered this when animating a polygon, but the same thing happens when trying to animate any PackedVector2Array.

In version 4.1.1 the animation was played in the continuous mode, but only with linear interpolation. Cubic was broken completely: it made polygon invisible and removed array data. Similar was mentioned here

@aXu-AP
Copy link
Contributor

aXu-AP commented Oct 23, 2023

I can confirm the regression happened between 4.2 dev5 and 4.2 dev6. So #80813 seems to be most plausible option? CC @TokageItLab

@TokageItLab
Copy link
Member

TokageItLab commented Oct 24, 2023

May be fixed by godotengine/godot-proposals#8085 with salvaging #66771.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants