Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-exclusive popup ConfirmationDialog fires canceled signal when pressing OK #85417

Closed
Yagich opened this issue Nov 27, 2023 · 1 comment · Fixed by #92460
Closed

Non-exclusive popup ConfirmationDialog fires canceled signal when pressing OK #85417

Yagich opened this issue Nov 27, 2023 · 1 comment · Fixed by #92460

Comments

@Yagich
Copy link
Contributor

Yagich commented Nov 27, 2023

Godot version

4.2rc2

System information

Linux/Manjaro

Issue description

Pretty much stated in the title. An AcceptDialog with exclusive set to false and popup_window set to true will fire the canceled signal. This happens both on embedded and non-embedded subwindows.

Steps to reproduce

  1. Make an AcceptDialog with exclusive set to false and popup_window set to true
  2. Subscribe to its' canceled and confirmed events
  3. Show the dialog, press OK and observe that both signals get fired.

Minimal reproduction project

accept-dialog-cancel-confirm.zip

Open the main scene and press OK and notice the prints.

@bruvzg
Copy link
Member

bruvzg commented Nov 27, 2023

Make an AcceptDialog with exclusive set to false and popup_window set to true

popup_window should not be used with a normal dialog. It is intended specifically for popup menus, combo box dropdowns and similar temporary windows and enables special logic to auto-close the window in multiple conditions, which is likely what's interfering with dialog logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants