Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to deselect Audio bus effects (including selecting nodes or files, switching tabs, etc.) #85478

Closed
IronBrandon opened this issue Nov 28, 2023 · 3 comments · Fixed by #85879

Comments

@IronBrandon
Copy link

Godot version

3.5.3.stable.official [6c81413]

System information

OS: Windows 11 - CPU: Intel Core i7-8700 @ 3.20GHz - GPU: NVIDIA GeForce GTX 1060 3GB

Issue description

When I create an effect on an Audio Bus, selecting it is permanent unless I select another effect.
I've had this issue for a while and, when first discovering thought to myself "Eh, somebody else probably found it, it's already fixed". That was about a year ago now (maybe longer), and it's still the exact same.

The way I'd expect it to work is it would deselect if I clicked anywhere outside of the effect itself or the Inspector window (or if I switch to the Output, Debugger, etc.).

Demonstration video

godot-bugreport-effectdeselection.mp4

Steps to reproduce

  1. Open a Godot project (happens in anyone for me) or create a new one
  2. Open the Audio tab
  3. Create an effect and select it or select an existing one
  4. Attempting to click outside the box will never deselect it. Attempting to delete a node or clicking DEL will only delete the effect (even when it's not visible).

Temporary Fix

Create a deselection effect on the same bus and delete it. While it is an easy fix, this can get in the way of many developers, as it did with me (it took me months to realize this).

Minimal reproduction project

N/A

@berrybus
Copy link
Contributor

For what it's worth, I was able to reproduce this on 3.5.3, but not on 4.1, so maybe some backporting is necessary?

Here are some recordings from 4.1 on Windows 11:

capture.mp4

The audio effect stays selected visually, but it looks like you can still delete other nodes.

deselect.mp4

You can also wiggle the effect around to get the visual selection to go away

@IronBrandon
Copy link
Author

IronBrandon commented Dec 1, 2023

For what it's worth, I was able to reproduce this on 3.5.3, but not on 4.1, so maybe some backporting is necessary?

Here are some recordings from 4.1 on Windows 11:

capture.mp4
The audio effect stays selected visually, but it looks like you can still delete other nodes.

deselect.mp4
You can also wiggle the effect around to get the visual selection to go away

This is an important issue (at least to me) because new developers will think the effects don't work. I probably would've switched engines if I hadn't figured it out, and it also delayed my game's sound design progress.

Edit: And I still think backporting fixes to 3.x is important because people still choose it over 4.x while it's improving, or they still have a big project on 3.x that they can't upgrade over to, or maybe they think 4.x is too bloated with features for their project

@Calinou
Copy link
Member

Calinou commented Dec 7, 2023

This wasn't actually fixed in 4.x – there's still no way to deselect a list of audio effects. What was fixed in 4.x was shortcut propagation issues, making the audio editor's Delete shortcut take priority over other shortcuts such as removing nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants