Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckBox and CheckButton don't change appearance when set to disabled. #8640

Closed
SirPigeonz opened this issue May 3, 2017 · 10 comments · Fixed by #37755
Closed

CheckBox and CheckButton don't change appearance when set to disabled. #8640

SirPigeonz opened this issue May 3, 2017 · 10 comments · Fixed by #37755

Comments

@SirPigeonz
Copy link
Contributor

Godot version: 3.0 master

Issue description:
CheckBox and CheckButton don't dim or change color when set to disabled.
Probably they are not finished in new Theme but not 100% sure.

@SirPigeonz
Copy link
Contributor Author

@djrm Any clue about this issue?

@djrm
Copy link
Contributor

djrm commented May 3, 2017

i have no idea, there is no such image as checkbox_disabled, are you sure that it dimed before?

@SirPigeonz
Copy link
Contributor Author

SirPigeonz commented May 3, 2017

Nope. It might be not theme issue after all. We have to investigate it.
Definitely something to fix, not sure how yet.

@ghost
Copy link

ghost commented May 15, 2017

Probably related to this issue, CheckBox and CheckButton hover style and font hover style are not showing when they are Checked/On.

@kubecz3k
Copy link
Contributor

kubecz3k commented Apr 7, 2018

First of all thank you for your report and sorry for the delay.

We released Godot 3.0 in January 2018 after 18 months of work, fixing many old issues either directly, or by obsoleting/replacing the features they were referring to.

We still have hundreds of issues whose relevance/reproducibility needs to be checked against the current stable version, and that's where you can help us.
Could you check if the issue that you described initially is still relevant/reproducible in Godot 3.0 or any newer version, and comment about its current status here?

For bug reports, please also make sure that the issue contains detailed steps to reproduce the bug and, if possible, a zipped project that can be used to reproduce it right away. This greatly speeds up debugging and bugfixing tasks for our contributors.

Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.

Thanks in advance.

Note: This message is being copy-pasted to many "stale" issues (90+ days without activity). It might happen that it is not meaningful for this specific issue or appears oblivious of the issue's context, if so please comment to notify the Bugsquad about it.

@ProbDenis
Copy link
Contributor

I can confirm what hickop said: Checkboxes don't show their hover style when they are checked.

@akien-mga akien-mga changed the title 3.0 Bug - CheckBox and CheckButton don't change appearance when set to disabled. CheckBox and CheckButton don't change appearance when set to disabled. Jun 7, 2018
@akien-mga
Copy link
Member

akien-mga commented Jun 7, 2018

CheckBox and CheckButton don't dim or change color when set to disabled.

I can confirm this is still valid in the current master branch. The text next to the Box or Button does get dimmed, but the image itself doesn't change.

On the other hand it didn't change either in 2.1, so it's not a bug, it's just a missing feature :)

I'll retag as enhancement.

Probably related to this issue, CheckBox and CheckButton hover style and font hover style are not showing when they are Checked/On.

That's a different IMO issue, I'll move it to a new ticket (edit: #19429).

@quasar-kyle-2
Copy link

Can confirm, still: CheckBox and CheckButton don't dim or change color when set to disabled. Would be nice to have a fix

@KoBeWi
Copy link
Member

KoBeWi commented Jun 4, 2019

In 328805a CheckButton has a proper disabled theme, but CheckBox only grays out text. I guess the whole CheckBox should be greyed out?

Here's a PR #28548 for reference how this could be fixed.

@Calinou
Copy link
Member

Calinou commented Jun 4, 2019

We could add disabled icons for CheckBox. However, it might be difficult to distinguish unchecked and disabled checkboxes with their non-disabled unchecked counterparts. Any suggestions? 🙂

It should be easy enough for checked checkboxes though (just make the tick semi-transparent).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants