Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging a connection from the input port in a visual shader results in an error #87337

Closed
YuriSizov opened this issue Jan 18, 2024 · 0 comments · Fixed by #87356
Closed

Dragging a connection from the input port in a visual shader results in an error #87337

YuriSizov opened this issue Jan 18, 2024 · 0 comments · Fixed by #87356

Comments

@YuriSizov
Copy link
Contributor

Tested versions

Reproduceable on master at 1952f64.

System information

Godot v4.3.dev (1952f64) - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3070 Ti Laptop GPU (NVIDIA; 31.0.15.3742) - 12th Gen Intel(R) Core(TM) i7-12700H (20 Threads)

Issue description

Dragging a new connection from an input port and dropping it to create a new node results in an error in the visual shader plugin.

ERROR: Condition "!shader_rid.is_valid()" is true. Returning: 0
   at: VisualShaderNodeParameterRef::get_parameters_count (scene\resources\visual_shader.cpp:3605)
scene\resources\visual_shader.cpp:3605 - Condition "!shader_rid.is_valid()" is true. Returning: 0

I couldn't reproduce this by dragging from an output port. Also, on a few occasions there was no error even for the input port, but otherwise it was reliably reproduceable.

Steps to reproduce

godot.windows.editor.dev.x86_64_2024-01-18_15-10-26.mp4

Minimal reproduction project (MRP)

N/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants