Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation Player not applying cubic keyframes correctly in 4.3dev2 #87637

Closed
zolrath opened this issue Jan 26, 2024 · 4 comments · Fixed by #87772
Closed

Animation Player not applying cubic keyframes correctly in 4.3dev2 #87637

zolrath opened this issue Jan 26, 2024 · 4 comments · Fixed by #87772

Comments

@zolrath
Copy link

zolrath commented Jan 26, 2024

Tested versions

Reproducible in 4.3dev2
Not reproducible in 4.3dev1
Not reproducible in 4.2

System information

Windows 11 - Godot 4.3dev2 - Compatibility

Issue description

I've got an AnimationPlayer from a 4.2 project animating the rotation of a PanelContainer at the root of my scene.

When opening my 4.2 project in 4.3dev2, the animation no longer works correctly and the first/last frame with 0 degrees rotation are left at odd rotations.
 

4.2 and 4.3dev2 Comparison

4.2 4.3dev2
4 2-1 4 3-1
4 2-2 4 3-2
4 2-3 4 3-3
4 2-4 4 3-4

Adding an extra frame to end

If I add an additional 0 degrees frame at the end, both the last and second to last frames properly show 0 degrees.

Extra Frame 1 Extra Frame 2
4 3-extra1 4 3-extra2

Steps to reproduce

  1. Create an Animation Player that rotates a panel container, 0.3 seconds long as shown above.
  2. IMPORTANT: Use cubic interpolation, linear will not produce the error.
  3. The rotation no longer matches the keyframe value.

I've copied over the offending panel into a MRP, along with a scene recreated in 4.3 using linear interpolation that doesn't seem to have the issue.

Minimal reproduction project (MRP)

AnimationPlayerBug.zip

I've included two scenes.
made_in_4_2_broken.tscn has the scene that showed the original issue reduced to its base parts.
made_in_4_3_seems_fine.tscn shows the same setup but with linear interpolation.

@Calinou
Copy link
Member

Calinou commented Jan 27, 2024

Can you test to see if it works in 4.3.dev1?

@zolrath
Copy link
Author

zolrath commented Jan 27, 2024

Seems to be fine in 4.3dev1

image

@bs-mwoerner
Copy link
Contributor

Might be caused by [e538ce3]'s changes to cubic interpolation.

Before:
grafik

After:
grafik

@zolrath zolrath changed the title Animation Player not applying keyframes correctly in 4.3dev2 Animation Player not applying cubic keyframes correctly in 4.3dev2 Jan 27, 2024
@TokageItLab
Copy link
Member

Sorry, I made a mistake in the argument there. Please test #87772 if you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants