Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDExtension hot reload does not check for null in initialization.deinitialize #87937

Closed
tishin opened this issue Feb 4, 2024 · 0 comments · Fixed by #87938
Closed

GDExtension hot reload does not check for null in initialization.deinitialize #87937

tishin opened this issue Feb 4, 2024 · 0 comments · Fixed by #87938
Labels
bug crash topic:gdextension
Milestone
4.3

Comments

@tishin
Copy link
Contributor

tishin commented Feb 4, 2024

Tested versions

Reproducible in: 4.3.dev [b4e2a24], 4.2.1.stable

System information

macOS 14.2.1

Issue description

Godot crashes trying to hot reload GDExtension when initialization.deinitialize method is not provided by extension developers.

Steps to reproduce

  1. Configure .gdextension file to include reloadable = true
  2. Build the extension library without providing initialization.deinitialize
  3. Open Godot
  4. Change something in extension, rebuild and replace the library
  5. Go back to Godot window

Minimal reproduction project (MRP)

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug crash topic:gdextension
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Add null check for GDExtension deinitialization tishin/godot
2 participants
@tishin @AThousandShips