Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime TileData modifications are discarded after reparenting #88605

Closed
KoBeWi opened this issue Feb 20, 2024 · 2 comments
Closed

Runtime TileData modifications are discarded after reparenting #88605

KoBeWi opened this issue Feb 20, 2024 · 2 comments
Assignees
Milestone

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Feb 20, 2024

Tested versions

4.3 dev3
4.3 1aab6e9
Does not happen in 4.2.1

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 30.0.15.1403) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

Issue description

When TileMap is reparented, the modifications from _tile_data_runtime_update() are discarded, but the method is not called again. Here I'm reparenting the TileMap and the method that disables collisions don't run:

godot_B2f0Mwo5KT.mp4

Steps to reproduce

  1. Use _tile_data_runtime_update() to change something
  2. Reparent the TileMap
  3. Notice that your changes are gone

Minimal reproduction project (MRP)

TileMapBug.tscn.txt

@KoBeWi KoBeWi added this to the 4.3 milestone Feb 20, 2024
@matheusmdx
Copy link
Contributor

Bisecting points to #87115 as culprit:

image

@akien-mga akien-mga moved this from Unassessed to Very Bad in 4.x Release Blockers May 15, 2024
@akien-mga akien-mga moved this from Very Bad to Bad in 4.x Release Blockers May 15, 2024
@groud
Copy link
Member

groud commented May 27, 2024

Tested with latest master, I cannot reproduce the bug with the provided MRP.
Could you confirm it is fixed on master?

@KoBeWi KoBeWi closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Bad
Development

No branches or pull requests

3 participants