Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioStreamPlaybackPolyphonic doesn't emit finished signal for each AudioStream neither allow get the reference from ID #88941

Open
gatomesa opened this issue Feb 28, 2024 · 5 comments

Comments

@gatomesa
Copy link

Tested versions

Godot 4.2.1

System information

Godot v4.2.1.stable - macOS 13.4.1 - Vulkan (Forward+) - integrated Apple M1 - Apple M1 (8 Threads)

Issue description

AudioStreamPlayers don't emit the finished signal after playing a stream from an Audio Playback track.

Steps to reproduce

Add an animation with an Audio Playback track. Connect the AudioStreamPlayer's finished signal to a method in a script, and do a print()

Minimal reproduction project (MRP)

N/A

@TokageItLab
Copy link
Member

TokageItLab commented Feb 28, 2024

AudioTrack uses AudioStreamPolyphonyc rather than a single AudioStream, so it is necessary to monitor the AudioStreams within AudioStreamPlaybackPolyphonic. (The method to get the currently playing stream may not be implemented yet...?)

@TokageItLab TokageItLab closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2024
@TokageItLab TokageItLab reopened this Feb 28, 2024
@TokageItLab TokageItLab changed the title AudioStreamPlayer doesn't emit finished() signal after playing a stream from an Audio Playback track AudioStreamPlaybackPolyphonic cannot get the currently playing AudioStream resource from ID Feb 28, 2024
@TokageItLab TokageItLab changed the title AudioStreamPlaybackPolyphonic cannot get the currently playing AudioStream resource from ID AudioStreamPlaybackPolyphonic cannot get the currently playing AudioStream reference from ID Feb 28, 2024
@TokageItLab TokageItLab changed the title AudioStreamPlaybackPolyphonic cannot get the currently playing AudioStream reference from ID AudioStreamPlaybackPolyphonic doesn't emit finished signal for each AudioStream neither allow get the reference from ID Feb 28, 2024
@Domeee
Copy link

Domeee commented Mar 6, 2024

On 4.2 I face the same issue. Running with v4.3.dev (master) resolves this issue for me.

@MJacred
Copy link
Contributor

MJacred commented Apr 5, 2024

This seems to be a duplicate issue:

AudioStreamPlaybackPolyphonic doesn't emit finished signal for each AudioStream

Afaik this is a design choice: finish will be emitted only after the very last AudioStream finished.

And this concern is already tracked here: #75089

[…] neither allow get the reference from ID

This sounds a bit too vague. But I reckon this fixes your concern: #86054 ?

@Domeee: The stream IDs you get all work? So #86054 is not necessary anymore?

@MJacred
Copy link
Contributor

MJacred commented May 7, 2024

@Domeee: reminder for my previous comment. The feedback would be much appreciated!

@Domeee
Copy link

Domeee commented May 11, 2024

@MJacred As far as I can tell, all stream IDs work. I instantiate a bunch of AudioStreamPlayer in _ready which are then used in a queue to play all sorts of sfxs. If I would not get all finishedevents, I would run ouf of players very fast. This was the case in 4.2 and is resolved in 4.3.dev. HTH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants