Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot interact with popups inside the editor #90137

Closed
adamscott opened this issue Apr 2, 2024 · 8 comments · Fixed by #89058
Closed

Cannot interact with popups inside the editor #90137

adamscott opened this issue Apr 2, 2024 · 8 comments · Fixed by #89058

Comments

@adamscott
Copy link
Member

Tested versions

v4.3.dev.custom_build [29b3d9e]

System information

Godot v4.3.dev (29b3d9e) - Fedora Linux 39 (Workstation Edition) - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX Vega (RADV VEGA10) () - AMD Ryzen 7 5800X 8-Core Processor (16 Threads)

Issue description

We cannot select text neither interact with it (e.g. click on a link) on an editor popup.

Capture.video.du.2024-04-02.10-54-09.webm
Capture.video.du.2024-04-02.10-55-44.webm

Steps to reproduce

  1. Highlight an inspector entry or a export entry.
  2. Try to select text from the popup.

Minimal reproduction project (MRP)

n/a

@KoBeWi
Copy link
Member

KoBeWi commented Apr 2, 2024

#48186 just made the tooltips disappear. They were never functional, so until there is actual use in interacting with them, there is no reason to change that.

@coppolaemilio
Copy link
Member

The biggest UX issue I see about this is when you actually don't want to interact with it. If you by mistake hovered for too long into an element and then you try to move your mouse somewhere else, the popups will likely cover that content and not go away. This can be annoying since you will have to hover in and out of the popups just to continue browsing the other inspector elements covered by it.

So, while I understand the desire to copy/interact with it, I don't think it is a solution if the popups is covering other elements that the user will want to interact with next and it triggers via hovering. If the user clicked on the element for the popup to show up, I think it wouldn't be a problem to keep it open so you could interact with it.

@adamscott
Copy link
Member Author

#48186 just made the tooltips disappear. They were never functional, so until there is actual use in interacting with them, there is no reason to change that.

In fact, something broke the behavior of #48186. It specifically had logic to not hide custom popups on hover.

@KoBeWi
Copy link
Member

KoBeWi commented Apr 2, 2024

The biggest UX issue I see about this is when you actually don't want to interact with it. If you by mistake hovered for too long into an element and then you try to move your mouse somewhere else, the popups will likely cover that content and not go away.

The tooltip could be closable with Escape or right-click.

@adamscott
Copy link
Member Author

The biggest UX issue I see about this is when you actually don't want to interact with it.

We could add more time to the delay to show a popup, to make sure the user really wants to see a popup.

@adamscott
Copy link
Member Author

adamscott commented Apr 2, 2024

@Sauermann I think this issue is Viewport related, isn't it?

@Sauermann
Copy link
Contributor

Sauermann commented Apr 2, 2024

Besides being Viewport related, this also affects platform-specific input handling. When the popup is displayed as a separate native OS Window, then it will be necessary to verify, that input events are sent to the correct native OS Window.
To me, this looks like a feature request for interacting with Tooltips.

@ajreckof
Copy link
Member

The biggest UX issue I see about this is when you actually don't want to interact with it. If you by mistake hovered for too long into an element and then you try to move your mouse somewhere else, the popups will likely cover that content and not go away.

The tooltip could be closable with Escape or right-click.

I think it would be better do go the other way and have a key to be able to interact with it. I remember seeing this somewhere and it felt really good (maybe baldur's gate?) as it wasn't blocking in any way and a simple click would pin the tooltip for interaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants