Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y-sort doesn't work properly #90739

Closed
Rindbee opened this issue Apr 16, 2024 · 6 comments · Fixed by #90749
Closed

Y-sort doesn't work properly #90739

Rindbee opened this issue Apr 16, 2024 · 6 comments · Fixed by #90749

Comments

@Rindbee
Copy link
Contributor

Rindbee commented Apr 16, 2024

Tested versions

4728ff3

System information

Linux Mint 21.3 (Virginia) - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1050 Ti (nvidia; 535.171.04) - Intel(R) Core(TM) i5-7300HQ CPU @ 2.50GHz (4 Threads)

Issue description

Recently noticed that Y-sort seems to be broken.

0.mp4

In the editor, it seems to be offset relative to the top left corner of the 2D Screen rather than the origin or its parent.

Steps to reproduce

Add some nodes, enable y_sort_enabled, and you can see that the drawing of the nodes is offset.

Minimal reproduction project (MRP)

N/A

@AThousandShips
Copy link
Member

It appears to happen when the parent isn't y-sorted but the children are, I've experienced this and that solved it for me

@akien-mga
Copy link
Member

Is it a regression, i.e. is it reproducible or not in 4.2 or earlier 4.3 dev builds?

@Rindbee
Copy link
Contributor Author

Rindbee commented Apr 16, 2024

Can't reproduce it in v4.3.dev5.official [c9c17d6].

@akien-mga akien-mga added this to the 4.3 milestone Apr 16, 2024
@akien-mga
Copy link
Member

CC @groud @KoBeWi @kleonc

@Sauermann
Copy link
Contributor

bisected to 2ed2ccc @rburing

@rburing
Copy link
Member

rburing commented Apr 16, 2024

Thanks a lot for catching this during the dev phase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Immediate Blocker
Development

Successfully merging a pull request may close this issue.

5 participants