-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embree compilation fails when specifying -march=x86-64-v3
version
#91217
Comments
-march=x86-64-v3
version
Upon further testing, it seems like Embree is the only thing causing compilation issues when using -march, when I disable the embree module godot compiles just fine at this x86 version. Every other module works perfectly fine. |
Embree uses preprocessor defines (such as The The #if !defined(__AVX__) || !defined(EMBREE_TARGET_SSE2) && !defined(EMBREE_TARGET_SSE42) || defined(__aarch64__)
template class BVHN<4>;
#endif which causes By adding the missing files, and changing the define from While adding the missing files would probably be OK for a regular Godot build (dead code elimination would probably negate the binary size impact of the added code), I'm not sure how we'd go about selecting the right The proper solution would probably be to prevent the compiler flags from enabling new instruction sets, using |
Tested versions
found in Godot v4.2.3.rc (c8356fb) (when I pulled version 4.2.2 there was a commit that changed it's version to 4.2.3 but nothing else was changed)
System information
Godot v4.2.3.rc (c8356fb) - Fedora Linux 40 (KDE Plasma) - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 7900 XT (RADV NAVI31) () - AMD Ryzen 9 7950X 16-Core Processor (32 Threads)
Issue description
When compiling the godot editor with the option
-march=x86-64-v3
it errors out giving this error NOTE: using-march=x86-64-v2
or-march=x86-64
does not error outSteps to reproduce
add
-march=x86-64-v3
to CCFLAGS and LINKFLAGSMinimal reproduction project (MRP)
N/A
The text was updated successfully, but these errors were encountered: