Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows input: Right click drag does not rotate the camera #92305

Closed
lyuma opened this issue May 24, 2024 · 7 comments · Fixed by #92742
Closed

Windows input: Right click drag does not rotate the camera #92305

lyuma opened this issue May 24, 2024 · 7 comments · Fixed by #92742

Comments

@lyuma
Copy link
Contributor

lyuma commented May 24, 2024

Tested versions

-Reproducible in 4.3.beta bd2300d
-Not reproducible in 4.2.1
-Not reproducible in 4.3 2efbc6b

System information

Godot v4.3.beta (bd2300d) - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3090 (NVIDIA; 31.0.15.3713) - Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 Threads)

Issue description

Right click drag does not seem to orbit the camera most of the time on windows.
This issue does not reproduce 100% of the time. Seems to happen under the same conditions in #92304 that Alt-Tab key gets stuck, but it is not necessary to use alt-tab to reproduce this issue.

Some times this issue will reproduce and alt-tab will not be sticky.

Steps to reproduce

  1. Hold right click.
  2. Drag the mouse. The camera may rotate for one frame, then stop.
  3. If it does not reproduce, open the editor again.
  4. One way to improve reproducibility appears to be to open multiple editors at once so that Godot gives the "Please confirm ... newer on disk" popup on some of them. But it might also be random.

Minimal reproduction project (MRP)

Reproduces on an empty new project

@SaracenOne
Copy link
Member

12fda2f may have caused the regression.

@akien-mga akien-mga changed the title windows input: Right click drag does not rotate the camera Windows input: Right click drag does not rotate the camera May 24, 2024
@akien-mga akien-mga modified the milestones: 3.x, 4.3 May 24, 2024
@akien-mga akien-mga moved this from Unassessed to Release Blocker in 4.x Release Blockers May 24, 2024
@roa-nyx
Copy link

roa-nyx commented Jun 1, 2024

Can confirm I didn't have this issue in 4.3.dev6, and now it's happening in 4.3.beta

Focusing a different window and then right clicking directly into the editor while keeping the mouse moving results in rotating for a frame again, but then it's stuck again.

@roa-nyx
Copy link

roa-nyx commented Jun 5, 2024

Thank you @Hilderin this fixes it for me :)

@matheusmdx
Copy link
Contributor

This was already solved in latest master 96a386f by #92415 (see #92759 (comment))

@roa-nyx
Copy link

roa-nyx commented Jun 25, 2024

@matheusmdx I managed to trigger this issue again in Godot 4.3-beta2, but I have no idea how.

I basically left Godot 4.3-beta2 on in the background, while I had a long zoom call. When I came back, I set a sky material on an environment node, but when I tried to rotate around, I had the same issue..

[Edit]: Restarting the editor fixed the issue. Again not sure how I triggered it though..

@matheusmdx
Copy link
Contributor

matheusmdx commented Jun 25, 2024

@matheusmdx I managed to trigger this issue again in Godot 4.3-beta2, but I have no idea how.

I basically left Godot 4.3-beta2 on in the background, while I had a long zoom call. When I came back, I set a sky material on an environment node, but when I tried to rotate around, I had the same issue..

[Edit]: Restarting the editor fixed the issue. Again not sure how I triggered it though..

If you find this issue again, please open a new issue so we'll try to find out what is happening. Try follow the steps as i described here #92759 (comment) to make sure is the same issue

Edit: I tried to reproduce this issue again in beta 2 using the same steps i used to test in beta 1 and i wasn't able to reproduce the problem in beta 2

@roa-nyx
Copy link

roa-nyx commented Jun 25, 2024

Thanks @matheusmdx, I'll open a new task once I figure out how to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Release Blocker
Development

Successfully merging a pull request may close this issue.

6 participants