Custom icons size in group editor is not standardized

[IkutiDev]

Tested versions

• Reproducible in v4.2.2.stable.official [15073af]

System information

Windows 11 Godot v4.2.2.stable.official [15073af]

Issue description

When assigning nodes inside group editor the sizes of custom icons are equal to the original picture size instead of being standardized to match other editor icons. Example screenshot:

Edit: Important to add I saw similar issues with other parts of editor which has been fixed since, so I'm guessing group editor just wasn't caught before, but it might not be too difficult to use the code that was used for inspector part of UI before.

Steps to reproduce

1. Create a scene with some nodes that have custom editor icons that are normally bigger than standard editor icons
2. Go to Node tab and select Groups category
3. Press Manage groups
4. Write a group name and press add
5. See that both list nodes not in group and nodes in group show the original size of custom icons which can be large instead of being similar to standard editor icon sizes, making using group editor difficult

Minimal reproduction project (MRP)

N/A

[mews6]

could i try to check this out?

[mews6]

Little update: it seems to be replicable in a linux build of v4.2.2.stable.official https://github.com/godotengine/godot/commit/15073afe3856abd2aa1622492fe50026c7d63dc1 (building from Pop!_OS 22.04). I'm new to the project so i might have to dig around for a while to check what is causing it. Maybe it isn't resizing the icons properly or something, but it doesn't seem OS-dependant. If someone has different results, please let me know.

[IkutiDev]

@mews6 I don't believe it's os oriented, my current guess is that it's related to this old issue #68962 where it was bugged for inspector and just that fixed wasn't added to group editor UI (guessing it's less used, most people assign groups via code and possibly don't use custom icons for nodes).

No one seems to be taking it right now so you are free to poke around. I would personally look into the PR that fixed the issue inside inspector. And than check if that fix can be applied to the file that creates the group editor UI.

[cselip]

@IkutiDev would this just be groups_editor.cpp? (the file that creates the group editor UI)

[IkutiDev]

@cselip Not 100% sure myself but I believe so, from a quick glance.

[mews6]

Currently taking a look at the file @cselip thinks might be the root of the problem, trying to check for anywhere where icons might be rezised, or if such a function even exists.

[Dowsley]

@mews6 this is the commit that adds resizing to the Editor 1522762

It seems to employ different strategies for each part of the editor.

[Dowsley]

#60965 removed the Group Editor and replaced it with an alternative that does not show which nodes that belong/don't belong in each group.

No node icon = problem solved. At least for now 😊

[elchukc]

#60965 removed the Group Editor and replaced it with an alternative that does not show which nodes that belong/don't belong in each group.

No node icon = problem solved. At least for now 😊

Do we close this issue then?