Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting a signal with a double click is too difficult #92382

Closed
miv391 opened this issue May 26, 2024 · 4 comments · Fixed by #95044
Closed

Connecting a signal with a double click is too difficult #92382

miv391 opened this issue May 26, 2024 · 4 comments · Fixed by #95044

Comments

@miv391
Copy link
Contributor

miv391 commented May 26, 2024

Tested versions

  • Reproducible in v4.3.dev6.mono.official [89850d5]

System information

Godot v4.3.dev6.mono - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 6GB (NVIDIA; 31.0.15.5212) - Intel(R) Core(TM) i5-3570K CPU @ 3.40GHz (4 Threads)

Issue description

Connecting a signal using a double click is quite difficult. It nees a lot of fast clicking, a normal double click doesn't usually work.

The culprit here is the popup window showing information about the signal. If I manage to double click before the popup pops up, all is fine and the "Connect Signal to a Method" window opens. But the popup pops up quite fast and after that the first mouse click (part 1 of a double click) just closes the popup. Then the second mouse click (part 2 of a double click) doesn't do anything. Then the popup pops up again, even if the mouse cursor is not moved.

The simplest (even if not perfect) solution could be to ensure that the popup does not popup again if the mouse cursor is not moved a decent amount. The at least after the first unsuccessful double click the second attempt would work.

kuva

Steps to reproduce

  1. Move cursor over some signal in Node's Signals view.
  2. Wait until the popup pops up.
  3. Double click --> "Connect Signal to a Method" window does not open.
  4. Be confused for a few seconds --> Popup pops up again.
  5. Goto 3.

Minimal reproduction project (MRP)

N/A

@matheusmdx
Copy link
Contributor

Tested with 4.3.dev6 and latest master be56cab and i can confirm the problem, also, if you open using --single-window the input problem stops but the tooltips don't dissapear when you hover the mouse in another signal

unknown_2024.05.26-10.44.mp4

Bisecting points to #89058 as the culprit:

image

@4X3L82
Copy link

4X3L82 commented Jun 2, 2024

If you keep wiggling the mouse, the popup doesn't pop-up and you can easily double-click (although it's a bit silly).

Wouldn't the cleanest (& simplest?) solution be that the first click of the double-click closes the pop-up but also passes it on to the next layer, so you can still click again for a double-click?

@akien-mga
Copy link
Member

Can you still reproduce this issue in 4.3.rc1? #93967 fixed one of the underlying issues and it's not clear whether this aspect of it was solved too.

@miv391
Copy link
Contributor Author

miv391 commented Jul 31, 2024

Can you still reproduce this issue in 4.3.rc1? #93967 fixed one of the underlying issues and it's not clear whether this aspect of it was solved too.

I can still reprocude this with v4.3.rc1.mono.official [e343dbb]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants