Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote debug button for Android not enabling automatically after installing build template for Gradle build #93531

Closed
BastiaanOlij opened this issue Jun 24, 2024 · 6 comments · Fixed by #94425

Comments

@BastiaanOlij
Copy link
Contributor

Tested versions

  • Reproducable in Godot 4.3 beta 2
  • Reproducable in Godot 4.3 commit 04bf7d4

System information

Windows 10 - Quest 3

Issue description

The remote debug button to push out a game to your android device, when you have "Use Gradle Build" stays disabled even after installing the Android build template. You have to restart the project before it finds out you've done so.

I'm assuming this is caused by a recent improvement where we're not adding entries to this menu that can't be run. However it is not reacting to resolving the reason.

Especially when you are testing fixes and continuously replacing the build template, it can get a little annoying :)

Steps to reproduce

  • Get a project that is designed to use android build templates
  • Delete the Android folder
  • Open it up in Godot
  • Notice the Remote debug button is disabled
  • Run Project->Install Android Build Template
  • Notice the Remote debug button is still disabled
  • Restart Godot
  • Notice the Remote debug button is now enabled with your entry

Minimal reproduction project (MRP)

n/a

@BastiaanOlij BastiaanOlij added this to the 4.3 milestone Jun 24, 2024
@akien-mga akien-mga added the bug label Jun 24, 2024
@akien-mga akien-mga moved this from Unassessed to Not Critical in 4.x Release Blockers Jun 24, 2024
@akien-mga akien-mga changed the title Remote debug button not enabling Remote debug button for Android not enabling automatically after installing build template for Gradle build Jun 24, 2024
@m4gr3d
Copy link
Contributor

m4gr3d commented Jun 24, 2024

@BastiaanOlij A quick workaround until the issue is fixed is to unplug and replug the Quest device.

@m4gr3d
Copy link
Contributor

m4gr3d commented Jun 24, 2024

cc @KoBeWi this is likely related to #87823

@BastiaanOlij
Copy link
Contributor Author

@BastiaanOlij A quick workaround until the issue is fixed is to unplug and replug the Quest device.

I found that to not work consistently, though it could be that I plug it back in too quickly :)

@KoBeWi
Copy link
Member

KoBeWi commented Jun 28, 2024

How is #87823 related? Is runnable Android preset optional to debug on device? Why does re-plugging fix the issue? A solution could be expanding #87823 to look for Android folder, though that's a periodic I/O operation, so rather meh.

@BastiaanOlij
Copy link
Contributor Author

How is #87823 related? Is runnable Android preset optional to debug on device? Why does re-plugging fix the issue? A solution could be expanding #87823 to look for Android folder, though that's a periodic I/O operation, so rather meh.

My guess is:
When the android build files aren't installed, the preset isn't runable and thus not added to the menu.
When the build files are installed, we are not re-evaluating the presets that become runable.

@m4gr3d
Copy link
Contributor

m4gr3d commented Jul 17, 2024

How is #87823 related? Is runnable Android preset optional to debug on device? Why does re-plugging fix the issue? A solution could be expanding #87823 to look for Android folder, though that's a periodic I/O operation, so rather meh.

My guess is: When the android build files aren't installed, the preset isn't runable and thus not added to the menu. When the build files are installed, we are not re-evaluating the presets that become runable.

The issue was due to #92032 and is being resolved in #94425.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Not Critical
Development

Successfully merging a pull request may close this issue.

5 participants