Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bezier handles are too long on short animations #93807

Closed
Arnklit opened this issue Jul 1, 2024 · 4 comments · Fixed by #93930
Closed

Bezier handles are too long on short animations #93807

Arnklit opened this issue Jul 1, 2024 · 4 comments · Fixed by #93930

Comments

@Arnklit
Copy link
Contributor

Arnklit commented Jul 1, 2024

Tested versions

4.3.beta2

System information

Godot v4.3.beta2 - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4070 Laptop GPU (NVIDIA; 31.0.15.4633) - AMD Ryzen 7 7840HS w/ Radeon 780M Graphics (16 Threads)

Issue description

Handles on Bezier keys are always 0.25 seconds long. This causes problems when working with short animations where the bezier curve will end up with an unwanted shape and you won't be able to get at the handles since they might be outside the view.

Godot_v4.3-beta2_win64_HPx768Pcqa.mp4

New key Handle length should at least be clamp to animation length, but something like half or quarter of animation length might be better. This would also be somewhat improved if the default handle type of new keys could be specified. It might make sense to have a default bezier handle type in editor settings.

Steps to reproduce

See video above
OR

  1. Create an animation and set the length to 0.2 seconds.
  2. Create a bezier anaimation with a key at the beginning and end of the animation and observe the curve and handles.

Minimal reproduction project (MRP)

NA

@TokageItLab
Copy link
Member

TokageItLab commented Jul 1, 2024

Since there is already an auto bezier function that depends on key spacing, it would be fine to have an option to enable it by default.

@Arnklit
Copy link
Contributor Author

Arnklit commented Jul 1, 2024

Since there is already an auto bezier function that depends on key spacing, it would be fine to have an option to enable it by default.

How does the Auto Bezier function work? I don't know about it and can't easily find it in the docs or UI.

@TokageItLab
Copy link
Member

TokageItLab commented Jul 1, 2024

By right-click:

image

See also godotengine/godot-proposals#3141 (comment)

@Arnklit
Copy link
Contributor Author

Arnklit commented Jul 1, 2024

Ahh I get you, I thought it was a mode that could be active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants