Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot is not finding methods in script (3.6.rc1) #94152

Closed
bitwes opened this issue Jul 9, 2024 · 4 comments
Closed

Godot is not finding methods in script (3.6.rc1) #94152

bitwes opened this issue Jul 9, 2024 · 4 comments

Comments

@bitwes
Copy link

bitwes commented Jul 9, 2024

Tested versions

3.6.rc1.official.cfc4a0eff

System information

Mac Sonoma 14.4.1 (23E224)

Issue description

I was testing GUT with 3.6.rc1.official.cfc4a0eff. Upon first launch it complained that it could not find a setter in gut.gd at line 38:

error(38,1):  The setter function isn't defined.

The setter exists. I commented out everything from setget forward and it complained about the next one. I commented out all the setget clauses and it ran, but then quickly errored stating different functions could not be found.

I have not tested any of the previous 3.6 versions. This works fine in 3.5.3 and the repo has not changed in awhile.

Steps to reproduce

  1. Open the following repo in 3.6.rc1.official.cfc4a0eff.
  2. Open addons/gut/gut.gd
  3. Notice that it says the setter is not defined.

https://github.com/bitwes/Gut/tree/godot_3x
or
git clone -b godot_3x https://github.com/bitwes/Gut

Minimal reproduction project (MRP)

See steps to reproduce

@timothyqiu
Copy link
Member

I bisected this regression to #61993

Reverting 5bcc3d4 fixes the issue.

@lawnjelly
Copy link
Member

@kdiduk
Given we are at RC, and the bug originally solved seems minor, sounds like we could:

  • Revert and fix in a point release after stable
  • Fix now if we can be confident of the fix and no more regressions

Akien's comments in #61993 (comment) makes it sounds like this is an area prone to regressions, but will wait to see what @kdiduk thinks.

@lawnjelly lawnjelly added this to the 3.6 milestone Jul 10, 2024
@kdiduk
Copy link
Contributor

kdiduk commented Jul 11, 2024

I would revert it now and make a better fix after 3.6 is released. Indeed we are at RC, the original issue was minor and the fix is prone to regressions. Meanwhile I will try to investigate it ASAP.

@akien-mga
Copy link
Member

Fixed by #94386.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants