Tripled key inputs after wake from sleep using "prefer Wayland"

[eobet]

Tested versions

4.3 rc2

System information

Godot v4.3.rc2 - Nobara Linux 40 (GNOME Edition) - Wayland - Vulkan (Mobile) - dedicated NVIDIA GeForce RTX 3050 Ti Laptop GPU - 11th Gen Intel(R) Core(TM) i7-11370H @ 3.30GHz (8 Threads)

Issue description

This is me typing "test" after opening the lid on my laptop with "prefer wayland" toggled on:

This does not always happen, but has never happened with "prefer wayland" toggled off.

No other application is affected by this (as evident from me typing this).

Typing functionality in Godot can be returned to normal by restarting the editor.

Steps to reproduce

• Use a laptop with Linux.
• Toggle the "prefer Wayland" option on in Godot & restart.
• Put the laptop to sleep.
• ???
• Type something in the Godot editor.

Minimal reproduction project (MRP)

N/A

[Riteo]

Sorry, I'm currently on vacation, so I have limited testing capabilities. I can't reproduce this on sway, with commit e343dbb (not the latest but that's what I had on hand).

Perhaps the keyboard objects aren't being cleaned up or something, not sure. Could you attach a debug Wayland log? The incantation is the usual: WAYLAND_DEBUG=1 godot --verbose > wayland.log 2>&1

[eobet]

Here is the log.

During the session, I typed "test" into the scene search then cleared it. Closed the lid on the laptop for a while. Opened it and again typed "test" into the search (and saw "ttteeesssttt", cleared it and closed Godot.

waylanddebug.log

[Riteo]

Thank you! It indeed looks like three keyboard objects are coexisting:

[1736003.781] wl_keyboard@132.key(107020, 69004954, 20, 1)
[1736003.861] wl_keyboard@126.key(107020, 69004954, 20, 1)
[1736003.894] wl_keyboard@33.key(107020, 69004954, 20, 1)

Curiously, none of those IDs match the keyboard used before suspending (wl_keyboard@29).

The issue seems to stem from GNOME reporting the available input devices ("capabilities") multiple times, perhaps from a sequential power up:

[1729947.857] wl_seat@13.capabilities(2)
[1729947.907]  -> wl_seat@13.get_keyboard(new id wl_keyboard@33)
[1729947.939] wl_seat@13.capabilities(6)
[1729947.964]  -> wl_seat@13.get_keyboard(new id wl_keyboard@126)
[1729947.991] wl_seat@13.capabilities(7)
[1729948.069]  -> wl_seat@13.get_keyboard(new id wl_keyboard@132)

(the above is shortened for convenience)

The compositor is doing a perfectly normal thing, but we just keep recreating keyboards every time we get a capabilities event with a keyboard in it. I'm actually quite surprised this didn't pop up sooner. I'll soon add some checks to avoid duplicate objects.

Note that I'm still on vacation, so I might be a tad slower at sending a patch. I'll see what I can do.

[eobet]

Vacation is more important than fixing bugs! 🤍