Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabContainer tabs move on select, but TabBar tabs do not [Regression] #97133

Closed
nathanfranke opened this issue Sep 18, 2024 · 1 comment · Fixed by #97209
Closed

TabContainer tabs move on select, but TabBar tabs do not [Regression] #97133

nathanfranke opened this issue Sep 18, 2024 · 1 comment · Fixed by #97209

Comments

@nathanfranke
Copy link
Contributor

nathanfranke commented Sep 18, 2024

Tested versions

System information

Arch Linux, kernel 6.10.9-arch1-2

Issue description

See video:

First element is TabBar, second element is TabContainer

2024-09-17.21-52-06.mp4

Tentative workaround in NOTIFICATION_RESIZED:

diff --git a/scene/gui/tab_bar.cpp b/scene/gui/tab_bar.cpp
index 90a6626b74..28bd03ff06 100644
--- a/scene/gui/tab_bar.cpp
+++ b/scene/gui/tab_bar.cpp
@@ -381,7 +381,6 @@ void TabBar::_notification(int p_what) {
                        int max_old = max_drawn_tab;
 
                        _update_cache();
-                       _ensure_no_over_offset();
 
                        if (scroll_to_selected && (offset != ofs_old || max_drawn_tab != max_old)) {
                                ensure_tab_visible(current);

Steps to reproduce

  • Launch MRP
  • press right arrow
  • select a tab

Minimal reproduction project (MRP)

test_tab_container.zip

@akien-mga
Copy link
Member

CC @kitbdev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants