Use _v shorthand for type traits and if constexpr where appropriate
#87871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vittorioromeo
force-pushed
the
use_v_shorthand
branch
from
2d527d4
to
7e88171
Compare
vittorioromeo
force-pushed
the
use_v_shorthand
branch
from
7e88171
to
55ed34e
Compare
Geometror
approved these changes
Feb 4, 2024
Thank you, I am glad to hear that! What is the general procedure for the PRs to get merged after review is approved? |
TL;DR: Currently I'm the one overseeing all merges, and they need to fit within relevant needs of the codebase at the time, and the release cycle (e.g. the imminent 4.3-dev3 snapshot). In this case this PR is likely fine to merge at any time as it seems to be a low risk refactoring, so it will be in the next batch. |
akien-mga
changed the title
_v shorthand for type traits and if constexpr where appropriate
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pure refactoring PR that shouldn't affect the behavior or Godot in any way or form. I've used the shorthand
_vnotation for type traits (which is more concise, and faster to compile on modern compilers) and promoted someifconstructs toif constexprwhere appropriate.Both of the changes had a precedent in the codebase.
BTW, I'm working on some more improvements to the internals, hope this kind of PR is appreciated!