Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ckb version has not been updated for a long time #353

Open
sunchengzhu opened this issue Apr 27, 2023 · 4 comments
Open

The ckb version has not been updated for a long time #353

sunchengzhu opened this issue Apr 27, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@sunchengzhu
Copy link
Contributor

I noticed that the latest update of the ckb version occurred a year ago. Is there any plan to update the ckb version and corresponding config files like ckb.toml ?
If updating the ckb version will make godwoken-v0 unavailable, just tell us how to modify the file in the readme.
image

@Flouse Flouse added the enhancement New feature or request label Apr 27, 2023
@blckngm
Copy link
Contributor

blckngm commented Jul 12, 2023

It's difficult to upgrade ckb because v0 deploy doesn't work with newer versions.

I have created a ckb2023 branch. It's using ckb2023 hardfork and builtin indexer (using builtin indexer is in itself not relevant to upgrading ckb, just something also blocked by v0 deploy):

https://github.com/godwokenrises/godwoken-kicker/tree/ckb2023

Will this work for your acceptance work?

@Flouse @jjyr How do we want to proceed with this?

@blckngm
Copy link
Contributor

blckngm commented Jul 12, 2023

The proper way is probably to update v0 to work with newer versions.

@Flouse
Copy link
Collaborator

Flouse commented Jul 13, 2023

The proper way is probably to update v0 to work with newer versions.

After thinking about it for a while, if the ckb2023 hardfork affects Godwoken v1, then it probably affects Godwoken v0 as well.
How long do you think it will take you to get Godwoken v0 working with the new CKB version?

@blckngm
Copy link
Contributor

blckngm commented Jul 13, 2023

After thinking about it for a while, if the ckb2023 hardfork affects Godwoken v1, then it probably affects Godwoken v0 as well. How long do you think it will take you to get Godwoken v0 working with the new CKB version?

A few days I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants