[BUG] currently does not support client body read timeout

[chenyukang]

From the code:

godwoken/crates/rpc-server/src/server.rs

Line 51 in 2d8ad35

let server = axum::Server::builder(incoming).serve(app.into_make_service());

Seems godwoken also has a similar issue with ckb, nervosnetwork/ckb#3880

I didn't verify it on godwoken, but from the code the rpc does not has a limit for a request, you can verify it with curl:

curl --location 'http://127.0.0.1:3000/rpc' \
-H 'content-length: 100' \
--header 'Content-Type: application/json' \
--data-raw '   {
        "id": 42,
        "jsonrpc": "2.0",
        "method": "@ping",
        "params": [
        ]
   }'

An possible fix is to add a timeout middleware: https://github.com/chenyukang/jsonrpc-utils/blob/810f6a36eec3ce5be8673c11311bf1dcc506c3f9/examples/server-timeout.rs#L39

[blckngm]

Godwoken rpc is usually proxied by web3 / nginx etc., not exposed directly.

But adding a client body size limit / timeout is pretty easy, so I will add it just in case.

[blckngm]

@chenyukang Just use TimeoutLayer from tower-http, no need for ServiceBuilder and HandleErrorLayer.

[chenyukang]

@chenyukang Just use TimeoutLayer from tower-http, no need for ServiceBuilder and HandleErrorLayer.

Got it, thanks.