Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can godwoken-bridge work without adding a network to the provider? #263

Open
ShookLyngs opened this issue Feb 10, 2023 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@ShookLyngs
Copy link
Collaborator

The feature

We've found a difference behaviour in LightGodwokenV0 and LightGodwokenV1:

  • V0 - The app works without adding a v0 network to the provider (the connected wallet)
  • V1 - The app needs to get L2 balance from the provider, therefore it has to add a v1 network to the provider

This single difference between v0 and v1 can be erased if we can just request the L2 balance from L2 RPC directly in v0 and v1, instead of requesting from the provider. But there might be other methods with the same issue.

So we need to spend more time reviewing the light-godwoken SDK, and think about how to make the SDK better from a larger perspective. If we could remove all dependencies on the provider (except for signing messages), maybe we don't have to add any network to the provider. This can be the next thing we do.

But on the other hand, if the app does not add a network to the provider, when the user wants to transfer L2 assets to others, do they have to add the network by themselves? It seems like a downside to the feature. @Flouse

Related segments

@ShookLyngs ShookLyngs added the enhancement New feature or request label Feb 10, 2023
@ShookLyngs ShookLyngs self-assigned this Feb 10, 2023
@Flouse
Copy link
Collaborator

Flouse commented Feb 10, 2023

on the other hand, if the app does not add a network to the provider, when the user wants to transfer L2 assets to others, do they have to add the network by themselves?

For this reason, I recommend adding networking for Godwoken v1.

Since Godwoken v0 is rarely used, we just need to keep https://bridge.godwoken.io/#/v0/withdrawal/ functional.
Let's make other things as simple as possible, with as few changes as possible.

cc @GitOfJason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants