You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We've found a difference behaviour in LightGodwokenV0 and LightGodwokenV1:
V0 - The app works without adding a v0 network to the provider (the connected wallet)
V1 - The app needs to get L2 balance from the provider, therefore it has to add a v1 network to the provider
This single difference between v0 and v1 can be erased if we can just request the L2 balance from L2 RPC directly in v0 and v1, instead of requesting from the provider. But there might be other methods with the same issue.
So we need to spend more time reviewing the light-godwoken SDK, and think about how to make the SDK better from a larger perspective. If we could remove all dependencies on the provider (except for signing messages), maybe we don't have to add any network to the provider. This can be the next thing we do.
But on the other hand, if the app does not add a network to the provider, when the user wants to transfer L2 assets to others, do they have to add the network by themselves? It seems like a downside to the feature. @Flouse
on the other hand, if the app does not add a network to the provider, when the user wants to transfer L2 assets to others, do they have to add the network by themselves?
For this reason, I recommend adding networking for Godwoken v1.
Since Godwoken v0 is rarely used, we just need to keep https://bridge.godwoken.io/#/v0/withdrawal/ functional.
Let's make other things as simple as possible, with as few changes as possible.
The feature
We've found a difference behaviour in LightGodwokenV0 and LightGodwokenV1:
This single difference between v0 and v1 can be erased if we can just request the L2 balance from L2 RPC directly in v0 and v1, instead of requesting from the provider. But there might be other methods with the same issue.
So we need to spend more time reviewing the light-godwoken SDK, and think about how to make the SDK better from a larger perspective. If we could remove all dependencies on the provider (except for signing messages), maybe we don't have to add any network to the provider. This can be the next thing we do.
But on the other hand, if the app does not add a network to the provider, when the user wants to transfer L2 assets to others, do they have to add the network by themselves? It seems like a downside to the feature. @Flouse
Related segments
The text was updated successfully, but these errors were encountered: