Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 A mistake in the limiter middleware source code comment #1789

Closed
qracer opened this issue Feb 20, 2022 · 0 comments · Fixed by #1790
Closed

📚 A mistake in the limiter middleware source code comment #1789

qracer opened this issue Feb 20, 2022 · 0 comments · Fixed by #1790

Comments

@qracer
Copy link

qracer commented Feb 20, 2022

There is the config.go file in the limiter package. The file contains definition of config for limiter middleware. It has a field Max which sets maximum amount of requests. According to the comment beside it implies number of connections during Duration seconds, but Duration field is deprecated and Expiration field to be used instead. The comment is also confusing because the doc page about the limiter middleware does not have any mention for the Duration field at all except for the comment itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant