Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: does not implement sync.Locker #45

Closed
rbcrwd opened this issue Oct 11, 2019 · 0 comments · Fixed by #66
Closed

docs: does not implement sync.Locker #45

rbcrwd opened this issue Oct 11, 2019 · 0 comments · Fixed by #66
Labels
documentation

Comments

@rbcrwd
Copy link

rbcrwd commented Oct 11, 2019

FYSA, contrary to the root README, this package does not implement the sync.Locker interface, primarily because Lock() has the wrong signature (returns an error rather than having no return). Feel free to close this as WONTFIX, but it'd be nice to update the doc if it's not something worth fixing in code.
@ldez ldez changed the title [documentation] Does not implement sync.Locker docs: does not implement sync.Locker Jun 26, 2024
@ldez ldez mentioned this issue Jun 27, 2024
Merged
@ldez ldez closed this as completed in #66 Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: remove reference to sync.Locker ldez/flock
2 participants
@ldez @rbcrwd