Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact people from https://awesome-go.com/ #20

Closed
zerkms opened this issue Jul 15, 2018 · 8 comments
Closed

Contact people from https://awesome-go.com/ #20

zerkms opened this issue Jul 15, 2018 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@zerkms
Copy link
Member

zerkms commented Jul 15, 2018

I think it would be helpful if we contacted https://awesome-go.com/ and explained the situation

This fork should be added with no doubts, but it's not certain to me whether the original one should be marked explicitly somehow.

@niaow niaow self-assigned this Jul 15, 2018
@niaow niaow added the enhancement New feature or request label Jul 15, 2018
@niaow
Copy link
Member

niaow commented Jul 15, 2018

I have submitted a pull request for this.

@zerkms
Copy link
Member Author

zerkms commented Jul 15, 2018

Probably removing satori's version is too aggressive. May be just add some clarification text additionally to the project description.

@theckman
Copy link
Member

theckman commented Jul 15, 2018

We should do this once we've cut a release and are feeling good about the README file. Right now this project is only going to be usable by people who use go get. Anything dealing with semantic versions is going to pull a broken version of the library.

Edit: Especially if we're considering more breaking changes.

@niaow
Copy link
Member

niaow commented Jul 15, 2018

The PR has been temporarily closed and will be re-opened after we have a release.

@niaow niaow added this to the 1.3.0 milestone Jul 15, 2018
@acln0 acln0 mentioned this issue Jul 18, 2018
@theckman
Copy link
Member

Removing this from the 2.0.0 milestone, since this is to happen after not before.

@theckman theckman removed this from the 2.0.0 milestone Jul 18, 2018
@niaow
Copy link
Member

niaow commented Jul 18, 2018

I can reopen this tonight

@theckman
Copy link
Member

@jadr2ddude now that #19 is merged I think you're all good to go.

@niaow
Copy link
Member

niaow commented Jul 23, 2018

The awesome-go PR has been merged.

@niaow niaow closed this as completed Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants