Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI status with hook #813

Closed
hickscorp opened this issue Dec 31, 2014 · 21 comments
Closed

CI status with hook #813

hickscorp opened this issue Dec 31, 2014 · 21 comments
Labels
🎯 feature Categorizes as related to a new feature

Comments

@hickscorp
Copy link

This feature request might not be one of the most easy, and is related to #5

The idea would be for Gogs to expose a simple API for continuous integration / deliveries system to be able to report back about specific commits / PR quality.

An example of how you set up Github to talk with Travis is explained here: http://stackoverflow.com/questions/19810386/showing-travis-build-status-in-github-repo

Basically, i have right now Gogs talk with my CI server in one way, to trigger builds within the CI system. What i would like to do is being able to configure the other way-communication, to allow Gogs to have visibility wether a specific commit / PR passes or fails the tests.

The exposed API should be template-based, or simple enough to be hook-able to any other web-hook based system, this way anyone could configure gogs with his favorite CI / CD system.

Tell me if i'm clear enough, i don't have the exact word for this process.

@hickscorp
Copy link
Author

@unknwon If you need more informations about this feature, i can provide you with good pointers. I have created a test project on my personnal server with a pull request. The pull request triggered a strider build, which in turn used the github-status plugin to send the result back to github.

Hope this will help if you're not familiar with the idea.

@unknwon unknwon added the 🎯 feature Categorizes as related to a new feature label Jan 22, 2015
@kageurufu
Copy link

👍 for this

@bhchew
Copy link

bhchew commented Dec 7, 2015

+1 Also just to clarify, will the hook be triggered during a PR submit or during accepting a PR (merge)?

@unknwon unknwon modified the milestone: 0.9.0 Dec 13, 2015
@unknwon unknwon changed the title CI / CD status with hook. CI / CD status with hook Dec 13, 2015
@cusspvz
Copy link

cusspvz commented Jan 13, 2016

+1

1 similar comment
@ekozan
Copy link

ekozan commented Jan 31, 2016

+1

@unknwon unknwon removed this from the 0.9.0 milestone Feb 7, 2016
@scruplelesswizard
Copy link

Has anyone started doing any work on this or is it still available?

@unknwon
Copy link
Member

unknwon commented Feb 29, 2016

@thecanadianbaker I don't think anyone one is working on it, but it is also not a easy thing to implemented (involves design concepts of Gogs, and such.).

@scruplelesswizard
Copy link

I agree that the proposed is not easily implemented, but I think we might
be looking at it the wrong way. I think that a much simpler implementation
would be to leave the responsibility of recording and storing the
information regarding builds with the build engine, and instead have Gog's
request that information using a standard internal interface at the time of
display. That means that we can implement a common interface within Gogs to
make the build status request using some standardized parameters, but it is
up to the implementing package to manage the interaction with the build
server.

Is this feasible and does it sound appropriate?
On Mon, Feb 29, 2016 at 6:19 AM 无闻 notifications@github.com wrote:

@thecanadianbaker https://github.com/thecanadianbaker I don't think
anyone one is working on it, but it is also not a easy thing to implemented.


Reply to this email directly or view it on GitHub
#813 (comment).

@unknwon
Copy link
Member

unknwon commented Feb 29, 2016

@thecanadianbaker This feature should be a part of the entire new system like GitHub's pull request merge checks.

Just the hook is easy, but that's not very extendable.

@unknwon unknwon added this to the 0.10.0 milestone Mar 6, 2016
@naggie
Copy link

naggie commented Mar 13, 2016

Very glad to see this has been added to a milestone. Great, thanks!

@migibert
Copy link

migibert commented Apr 3, 2016

+1

1 similar comment
@renewsorensen
Copy link

+1

@farooq-khan-nxt
Copy link

farooq-khan-nxt commented Apr 17, 2016

+1
Something like when you raise a Pull request CircleCI automatically builds and lets us know if pull request will pass build or fail.
And after the Pull Requests is merged again builds

@hz
Copy link

hz commented Apr 20, 2016

+n, n > 好多好多。 gogs后面的团队好给力。

@neithere
Copy link

I don't see how Gogs could have any practical value without this feature.

@strk
Copy link
Contributor

strk commented Jul 15, 2016

How github implements this: https://developer.github.com/v3/repos/statuses/

@tboerger
Copy link
Contributor

IMHO this feature can be integrated quite easy if you do it like github

@unknwon unknwon modified the milestones: 0.10.0, 0.11.0 Jul 16, 2016
@cblomart
Copy link

Would realy love to see this type of integration!
This allows a more automated control of what enters a repo. (coding style / tests / build). All automaticaly reported :)
👍

@kmadel
Copy link
Contributor

kmadel commented Sep 2, 2016

Is anyone working on this one yet?

@strk
Copy link
Contributor

strk commented Sep 2, 2016

On September 2, 2016 5:46:06 PM CEST, Kurt Madel notifications@github.com wrote:

Is anyone working on this one yet?

Not me. Planning to start?
--strk;

Sent from hand-held device, sorry for brevity

ethantkoenig pushed a commit to ethantkoenig/gogs that referenced this issue Feb 11, 2017
@unknwon unknwon changed the title CI / CD status with hook CI status with hook Feb 24, 2017
@unknwon unknwon modified the milestones: 0.11, 0.12 Mar 7, 2017
@unknwon
Copy link
Member

unknwon commented Nov 16, 2017

Merge this thread to #4631.

@unknwon unknwon closed this as completed Nov 16, 2017
@gogs gogs locked and limited conversation to collaborators Nov 16, 2017
@unknwon unknwon removed this from the 0.13 milestone Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🎯 feature Categorizes as related to a new feature
Projects
None yet
Development

No branches or pull requests