Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add information of gogo/protobuf version as a comment in generated go source files. #419

Closed
c-bata opened this issue Jun 18, 2018 · 3 comments

Comments

@c-bata
Copy link

c-bata commented Jun 18, 2018

Hi. First, I want to say thank you for developing. This go source files generator is really flexible.

When I reviewed pull requests including changes of *.pb.go, It's difficult to identify what's gogo/protobuf version is used when generating *.pb.go from the diffs. Perhaps my colleague generated by using old version of gogo/protobuf. That's why I opened this suggestion.

But I know we can't change the outputs of previous versions because the consistency of generated files are really important in this project. So I suggest this for future releases.

How do you feel about this suggestion?
Thanks.

@awalterschulze
Copy link
Member

What do you think about this issue on golang/protobuf
golang/protobuf#524

We would most probably merge a change they make there.
If you take your request there, then gogoprotobuf can stay more consistent with its origin.
Would you mind?

@c-bata
Copy link
Author

c-bata commented Jun 18, 2018

I think your thought is more reasonable than me. Thanks for your quick response 👍

@c-bata c-bata closed this as completed Jun 18, 2018
@awalterschulze
Copy link
Member

My pleasure and good luck :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants