Theme submission - Tandoori Hugo Theme

[Gnappuraz]

Theme submission

Link to my theme repository: https://github.com/Gnappuraz/tandoori-hugo

I made sure that...

• the repository contains a good README.md describing my theme
• an open source license has been added to LICENSE.md
• all metadata have been added to theme.toml
• screenshots have been added in the images/ folder with the required dimensions
• in case I'm using a customized demo via the exampleSite folder that
  • https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains
  • I tested that my theme's demo works with the content directory of gohugoio/HugoBasicExample
• I tested my theme against the gohugoio/HugoBasicExample
  • I've checked the developer tools' console in my browser for error messages
• in case my theme is using Hugo Pipes features like toCSS and PostCSS that I have committed the /resources directory with all generated assets, for my theme to work in the basic version of Hugo

[onedrawingperday]

Hello @Gnappuraz

Thank you for submitting this fork of the Beautiful Hugo theme.

However you need to list the new features that you have developed on top of the original theme in the README. Currently it is not very clear.

Also I have seen that you mention pygments configuration parameters in the README. However pygments has been removed from Hugo since v0.60.0 and these parameters will no longer have any effect since the new default is Chroma and code highlighting is also enabled by default. See: https://gohugo.io/content-management/syntax-highlighting/#highlighting-in-code-fences

Once you look into the above please let me know so that I can review your theme further.

[Gnappuraz]

Hi @onedrawingperday, sorry for the late response but it has been a hell of a week ;). to answer your concerns:

• I removed support for everything but the default Chroma (this way is easier).
• I made clear that this fork is just a restyle, I actually did not develop any new feature, for the most part I just fiddled with the css.
• I increased the min supported version to v0.60.0

[onedrawingperday]

@Gnappuraz

I have noticed the following issues while reviewing your theme:

• There is a stray default.md under the root of the theme repo. The same file is also present under /archetypes/.

• In the theme submission guidelines we mention that relative protocol URLs should be avoided. You need to provide the https protocol in the links contained in https://github.com/Gnappuraz/tandoori-hugo/blob/master/layouts/partials/share-links.html

• The content of the theme demo will be inherited from the hugoBasicExample repository. Therefore the links you have provided for the Samples menu items need to point to the URLs of the respective content files from the above repo.

Please change line 71 of the exampleSite/config.toml to url = "post/math-typesetting" and line 77 to url = "post/markdown-syntax"

Once you look into the above please let me know.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. Feel free to ask questions. We're glad to help.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.