Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support for fallbacks with context #128

Open
psrajat opened this issue Jan 27, 2022 · 0 comments · May be fixed by #129
Open

feat: Support for fallbacks with context #128

psrajat opened this issue Jan 27, 2022 · 0 comments · May be fixed by #129

Comments

@psrajat
Copy link

psrajat commented Jan 27, 2022 •
edited
Loading

Hi Gojek Team!

The fallback function provided by heimdall's Hystrix Client doesn't support context.Context.

While going through afex/hystrix-go, I found that it does support a fallback function with context:

type fallbackFuncC func(context.Context, error) error

Link: https://github.com/afex/hystrix-go/blob/master/hystrix/hystrix.go#L13
This can be used alongwith DoC() instead of Do()

func DoC(ctx context.Context, name string, run runFuncC, fallback fallbackFuncC) error {

Link: https://github.com/afex/hystrix-go/blob/master/hystrix/hystrix.go#L217

This is however a breaking change.
Let me know if there's other way.

Thanks!
@psrajat psrajat linked a pull request Jan 27, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feat] fallback func with context psrajat/heimdall
1 participant
@psrajat