Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode character display error in windows10 powershell or windows terminal #451

Closed
zerobikappa opened this issue Aug 21, 2020 · 4 comments
Labels

Comments

@zerobikappa
Copy link

zerobikappa commented Aug 21, 2020

If using Powershell or Windows Terminal to run lf, the console would insert whitespace between every unicode character.
For example, "テストフォルダ1" would be shown as "テ ス ト フ ォ ル ダ 1".
Windows cmd does not have this problem.
Is this lf's issue or shall I report to microsoft?

@gokcehan
Copy link
Owner

@zerobikappa I think it is a lf problem but I'm still not 100% sure. I need to investigate more to be sure. Marking this as a bug in the meantime.

On my windows machine, this file is displayed correctly in the terminal when not using lf, that is these characters are displayed as wide characters occupying two cells, even though these characters are not being shown with my cmd and powershell terminal fonts but only shown properly on windows terminal. If you think there is an unexpected behavior in terminal when not using lf, then you may report the issue to microsoft as well.

@gokcehan gokcehan added the bug label Aug 22, 2020
@zerobikappa
Copy link
Author

zerobikappa commented Aug 23, 2020

The files can be shown correctly when not using lf.
While using lf, only cmd with codepage 936 or 932 can have correct output.
cmd with chcp 65001 would have this error, powershell and windows terminal have the same issue as well no matter using which codepage.

@gokcehan
Copy link
Owner

@zerobikappa It seems that this issue is related to termbox (our terminal ui library), which is not maintained anymore. There is an ongoing PR #439 to replace termbox with tcell, which doesn't seem to have this problem.

@gokcehan
Copy link
Owner

@zerobikappa I have now pushed a new release r17 with the new tcell terminal library. Closing this issue. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants