Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic: the parameter is incorrect #479

Closed
JavierCorralLizarraga opened this issue Oct 7, 2020 · 5 comments
Closed

Panic: the parameter is incorrect #479

JavierCorralLizarraga opened this issue Oct 7, 2020 · 5 comments
Labels

Comments

@JavierCorralLizarraga
Copy link

Hi,
Recently I noticed I was using an older version of LF, the one that chocolatey installs on windows (R12) so I updated it for myself and now I run the latest version.
But I used to do the command ":delete" on a toggled file and it'd work as expected. Now that I try to use that command it throws the error shown in the image (Its in spanish but the traduction is "panic: the parameter is incorrect").
It does work as expected on some terminal emulators I tried (Hyper and the new windows terminal) inside my machine but not for the default CMD and PowerShell and Alacritty.

image

@tarasyarema
Copy link
Contributor

Hi, I tried to replicate it with the HEAD branch on a Windows 10 machine using Powershell Core (7.0.1), old Powershell and cmd.exe and had no errors. Also I tried using Alactritty.

Maybe there's some issue with the Alacritty version?

I would try to rebuild the lf binary in case there were some package version issues.

@gokcehan
Copy link
Owner

gokcehan commented Oct 8, 2020

@JavierCorralLizarraga By latest version, do you mean the master branch or r16? If you built from the source, can you make sure you compiled with module-aware mode (i.e. GO111MODULE=on), and also maybe try one of our prebuilt binaries for r16 from the releases page?

@gokcehan gokcehan added the bug label Oct 8, 2020
@JavierCorralLizarraga
Copy link
Author

I am using the prebuilt binaries for R16 with extension "-amd64" (which I suppose is for the 64-bit systems)
I tried replacing it with a fresh one but the same happened, then I tried with the other binaries with extension "386" but it detected it as a virus and wouldn't let me download it.
image

@gokcehan
Copy link
Owner

gokcehan commented Oct 8, 2020

@JavierCorralLizarraga Your backtrace shows it panics in a termbox.SetCursor function. Termbox have some resize bugs in windows which might be related, though I can't reproduce the issue on my machine. On the bright side, we have already switched to a new terminal ui library in master branch. It is strongly possible that this issue is already resolved on its own in the master. If you have go installed on your machine, you can try to build from the source to see if it works. I'm hoping to push a new release r17 this weekend, so you can also wait for the new release if you like.

That virus alert is more worrying to me, though it is likely a false positive. Binaries are directly uploaded from travis to github, and I don't see much chance of a malware infection in that workflow. I tried checking the file with virustotal:

https://www.virustotal.com/gui/file/1da57c29def541eed068eab120f3c0607a8d573ca5daefada97ae101637f4e3a/detection

A recent scan shows 6/63 detected. As far as I understand, inconsistency among antivirus programs here is a strong indication of a false positive. I have also checked previous versions r15 and r14 and they don't seem to have any problems with windows defender. So it is highly possible this will be resolved on its own as well in the next release.

@gokcehan
Copy link
Owner

I have pushed a new release r17 some time ago which should likely work as intended. Closing this issue now. Feel free to report back here if the problem persists and I can reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants