-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring over ValidationHelper functionality from v4 branch #16
Comments
I was wondering about the implementation of the leeway: |
Just ran into the "token used before issued" error today for the first time, after things had been working fine previously. The discussion at #98 referenced this issue. Are there any plans to implement it and disregard the pre-IAT check? |
In a world with infinite time, yes :) Currently I am waiting for #108 to be merged. This one will be next. |
Awesome, appreciate your work! |
it's been merged 👀 :) |
I had a quick look yesterday and I am not sure if we can port this over in a backwards compatible manner, since the interface of |
This is something we relied on from the old library as we ran on the preview version and would help us move to adopt this port. |
Yes, we also rely in this functionality from the old library :) @oxisto , regarding your statement below:
So, what are the intended functionality that are targeted in v4.x? |
Please see #211 for an ongoing discussion how to proceed. |
Fixed by #234 |
The v4 branch has a nice validation helper struct which combines a lot of the functionality of the
Validate
functions. It might be nice to re-implement that and slowly move existing functionality to it.This would include things that have been on the wishlist in other forks, such as having leeway when validating timestamps (see form3tech-oss/jwt-go#12).
The text was updated successfully, but these errors were encountered: