-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling and migration of original project PRs #7
Comments
Note that is is important to keep notified the original reporter, either by reference via addendum on the migrated issue or by CCing then via a new comment in the thread This is a bit trickier, since whoever performs the migration will be the owner of the commit and not the original author, so the credit to the original author must be addressed by all means possible if the PR goes forward |
I have identified one or two interesting PRs and tried to start a conversation, whether the original authors want to migrate their code. For all sort of (copyright) reasons, I would not suggest just taking the code. Even if you provide a reference, it's really a grey area. So I would prefer, if the authors would move over their commits. |
I haven't thought about that at a first glance but I agree it's a delicate nuance, so we'll leave it at suggestions pointing to this repo then. We can still do our implementations of the same ideas though (albeit more time consuming and might still have possible frictions with the original author of the PR) |
@mfridman @ripienaar @Waterdrips If you guys agree we can leave at this and close this issue to keep it as a guideline |
Yes agree we can’t just take the PRs. |
We have to define how to deal with the original project's PRs
We can either:
The text was updated successfully, but these errors were encountered: