Generalize FinalizeManifestAndLock

- Removes gopathScanner's FinalizeManifestAndLock() and its usage.
- Adds using removeTransitiveDependencies() to remove unused
constraints.
- Changes rootAnalyzer's FinalizeManifestAndLock to log feedback for new
constraints and locked projects only.

Author: darkowlzz

cmd/dep/gopath_scanner.go

@@ -134,27 +134,6 @@ func (g *gopathScanner) overlay(rootM *dep.Manifest, rootL *dep.Lock) {
 	}
 }
 
-func (g *gopathScanner) FinalizeRootManifestAndLock(m *dep.Manifest, l *dep.Lock) {
-	// Iterate through the new projects in solved lock and add them to manifest
-	// if direct deps and log feedback for all the new projects.
-	for _, x := range l.Projects() {
-		pr := x.Ident().ProjectRoot
-		newProject := true
-		// Check if it's a new project, not in the old lock
-		for _, y := range g.origL.Projects() {
-			if pr == y.Ident().ProjectRoot {
-				newProject = false
-			}
-		}
-		if newProject {
-			// If it's in notondisk, add to manifest, these are direct dependencies.
-			if _, ok := g.pd.notondisk[pr]; ok {
-				m.Constraints[pr] = getProjectPropertiesFromVersion(x.Version())
-			}
-		}
-	}
-}
-
 func trimPathPrefix(p1, p2 string) string {
 	if fs.HasFilepathPrefix(p1, p2) {
 		return p1[len(p2):]

cmd/dep/init.go

@@ -140,15 +140,16 @@ func (cmd *initCommand) Run(ctx *dep.Ctx, args []string) error {
 		return err
 	}
 
-	gs := newGopathScanner(ctx, directDeps, sm)
 	if cmd.gopath {
+		gs := newGopathScanner(ctx, directDeps, sm)
 		err = gs.InitializeRootManifestAndLock(p.Manifest, p.Lock)
 		if err != nil {
 			return err
 		}
 	}
 
 	rootAnalyzer.skipTools = true // Don't import external config during solve for now
+	copyLock := *p.Lock           // Copy lock before solving. Use this to separate new lock projects from solved lock
 
 	params := gps.SolveParameters{
 		RootDir:         root,
@@ -174,10 +175,7 @@ func (cmd *initCommand) Run(ctx *dep.Ctx, args []string) error {
 	}
 	p.Lock = dep.LockFromSolution(soln)
 
-	rootAnalyzer.FinalizeRootManifestAndLock(p.Manifest, p.Lock)
-	if cmd.gopath {
-		gs.FinalizeRootManifestAndLock(p.Manifest, p.Lock)
-	}
+	rootAnalyzer.FinalizeRootManifestAndLock(p.Manifest, p.Lock, copyLock)
 
 	// Run gps.Prepare with appropriate constraint solutions from solve run
 	// to generate the final lock memo.

cmd/dep/root_analyzer.go

@@ -126,39 +126,40 @@ func (a *rootAnalyzer) DeriveManifestAndLock(dir string, pr gps.ProjectRoot) (gp
 	return gps.SimpleManifest{}, nil, nil
 }
 
-func (a *rootAnalyzer) FinalizeRootManifestAndLock(m *dep.Manifest, l *dep.Lock) {
-	// Remove dependencies from the manifest that aren't used
-	for pr := range m.Constraints {
-		var used bool
-		for _, y := range l.Projects() {
-			if pr == y.Ident().ProjectRoot {
-				used = true
-				break
-			}
-		}
-		if !used {
-			delete(m.Constraints, pr)
-		}
-	}
-	// Pick the direct dependencies from the solution lock and add to manifest.
-	// This is done to fill up the manifest constraints with the dependencies
-	// solved over the network.
+func (a *rootAnalyzer) FinalizeRootManifestAndLock(m *dep.Manifest, l *dep.Lock, ol dep.Lock) {
+	a.removeTransitiveDependencies(m)
+
+	// Iterate through the new projects in solved lock and add them to manifest
+	// if they are direct deps and log feedback for all the new projects.
 	for _, y := range l.Projects() {
 		var f *fb.ConstraintFeedback
 		pr := y.Ident().ProjectRoot
+		// New constraints: in new lock and dir dep but not in manifest
 		if _, ok := a.directDeps[string(pr)]; ok {
-			pp := getProjectPropertiesFromVersion(y.Version())
-			if pp.Constraint != nil {
-				m.Constraints[pr] = pp
-				pc := gps.ProjectConstraint{Ident: y.Ident(), Constraint: pp.Constraint}
-				f = fb.NewConstraintFeedback(pc, fb.DepTypeDirect)
-			} else {
-				f = fb.NewLockedProjectFeedback(y, fb.DepTypeDirect)
+			if _, ok := m.Constraints[pr]; !ok {
+				pp := getProjectPropertiesFromVersion(y.Version())
+				if pp.Constraint != nil {
+					m.Constraints[pr] = pp
+					pc := gps.ProjectConstraint{Ident: y.Ident(), Constraint: pp.Constraint}
+					f = fb.NewConstraintFeedback(pc, fb.DepTypeDirect)
+				} else {
+					f = fb.NewLockedProjectFeedback(y, fb.DepTypeDirect)
+				}
+				f.LogFeedback(a.ctx.Err)
 			}
 		} else {
-			f = fb.NewLockedProjectFeedback(y, fb.DepTypeTransitive)
+			// New locked projects: in new lock but not in old lock
+			newProject := true
+			for _, opl := range ol.Projects() {
+				if pr == opl.Ident().ProjectRoot {
+					newProject = false
+				}
+			}
+			if newProject {
+				f = fb.NewLockedProjectFeedback(y, fb.DepTypeTransitive)
+				f.LogFeedback(a.ctx.Err)
+			}
 		}
-		f.LogFeedback(a.ctx.Err)
 	}
 }