Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Move to the format we actually intend for the manifest and lock #26

Closed
sdboyer opened this issue Dec 3, 2016 · 2 comments
Closed

Move to the format we actually intend for the manifest and lock #26

sdboyer opened this issue Dec 3, 2016 · 2 comments

Comments

@sdboyer
Copy link
Member

sdboyer commented Dec 3, 2016

I think there's general agreement among us four that JSON is not what we want to use. I know that @freeformz and I both lean TOML. But we're gonna have to do this, and probably sooner rather than later.

Unfortunately, there's a wrinkle: one of the major arguments for using YAML or TOML over JSON is that both of those formats support comments, and JSON does not. However, neither BurntSushi/toml nor go-yaml/yaml appear to support encoding comments. idk about other implementations, but...well, that really sucks. (This knowledge courtesy of the cockroachdb folks, reporting it about glide: Masterminds/glide#691)

I don't know where that leaves us, but the clock is ticking.

@sdboyer
Copy link
Member Author

sdboyer commented Dec 17, 2016

so, I feel like the thing to do about this is...once we open up this repo, we basically put out a note saying, "hey, if some awesome Gopher wants to get support for proper comment handling into one of these encoding libs by X date, then we'll use it. otherwise, we'll have to stick with JSON"

@sdboyer
Copy link
Member Author

sdboyer commented Jan 23, 2017

closing in favor of #119

@sdboyer sdboyer closed this as completed Jan 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant