Skip to content
This repository has been archived by the owner on Jan 16, 2021. It is now read-only.

Support for vgo aware import paths #558

Closed
myitcv opened this issue Jun 13, 2018 · 6 comments
Closed

Support for vgo aware import paths #558

myitcv opened this issue Jun 13, 2018 · 6 comments

Comments

@myitcv
Copy link
Member

myitcv commented Jun 13, 2018 •
edited
Loading

Edit: retitled to reflect what I'm trying to achieve here, namely minimal support within gddo for vgo-aware import paths.

Is godoc.org running 1.10.3?

Per https://golang.org/doc/devel/release.html#go1.10.minor, 1.10.3 includes minimal support to the go command for the vgo transition. As such it will be essential to correctly resolve any projects/repos that convert to Go modules before the release of Go 1.11.

I ask because the following fails to resolve: https://godoc.org/?q=myitcv.io%2Fblah2

Despite the <meta> tags being apparently correct:

$ curl https://myitcv.io/blah2?go-get=1

<!DOCTYPE html>
<html>
<head>
        <meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
        <meta name="go-import" content="myitcv.io git https://github.com/myitcv/x">
        <meta name="go-import" content="myitcv.io/blah2 mod https://raw.githubusercontent.com/myitcv/pubx/master">
        <meta name="go-source" content="myitcv.io https://github.com/myitcv/x/wiki https://github.com/myitcv/x/tree/master{/dir} https://github.com/myitcv/x/blob/master{/dir}/{file}#L{line}">
        <meta http-equiv="refresh" content="0; url=https://godoc.org/myitcv.io/blah2">
</head>
<body>
Redirecting to docs at <a href="https://godoc.org/myitcv.io/blah2">godoc.org/myitcv.io/blah2</a>...
</body>
</html>

Thanks
@ghost
Copy link

ghost commented Jun 13, 2018

Upgrade to 1.10.3 will probably not help with the actual issue because the service does not use go get.

@myitcv myitcv changed the title Is godoc.org running 1.10.3? Support for vgo aware import paths Jun 26, 2018
@myitcv
Copy link
Member Author

myitcv commented Jun 26, 2018

I've mailed https://go-review.googlesource.com/c/gddo/+/120817 to fix this; would appreciate if someone could please take a look. Thanks

@myitcv
Copy link
Member Author

myitcv commented Jun 27, 2018

@shantuo thanks for merging the CL. Is there anything we now need to do to redeploy?

@shantuo
Copy link
Contributor

shantuo commented Jun 27, 2018

@myitcv I'll do a redeploy shortly, will report back then.

@shantuo
Copy link
Contributor

shantuo commented Jun 27, 2018

The change is live now, thanks for the fix!

@myitcv
Copy link
Member Author

myitcv commented Jun 27, 2018

Great, thanks. https://godoc.org/myitcv.io/blah2 now resolves properly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@myitcv @shantuo