Skip to content

Commit 1d5298d

Browse files
committed
doc/go1.17: document net/... changes
For #44513. Fixes #46014. Fixes #46015. Fixes #46016. Fixes #46017. Change-Id: I356483d68d07159281dfe2ea1e49430ddf200973 Reviewed-on: https://go-review.googlesource.com/c/go/+/322891 Trust: Damien Neil <dneil@google.com> Run-TryBot: Damien Neil <dneil@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
1 parent 0fbecec commit 1d5298d

File tree

2 files changed

+18
-7
lines changed

2 files changed

+18
-7
lines changed

doc/go1.17.html

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -418,15 +418,20 @@ <h3 id="minor_library_changes">Minor changes to the library</h3>
418418
<dl id="net"><dt><a href="/pkg/net/">net</a></dt>
419419
<dd>
420420
<p><!-- CL 272668 -->
421-
TODO: <a href="https://golang.org/cl/272668">https://golang.org/cl/272668</a>: add IP.IsPrivate
421+
The new method <a href="/pkg/net/#IP.IsPrivate"><code>IP.IsPrivate</code></a> reports whether an address is
422+
a private IPv4 address according to <a href="http://tools.ietf.org/html/rfc1918">RFC 1918</a>
423+
or a local IPv6 address according <a href="http://tools.ietf.org/html/rfc4193">RFC 4193</a>.
422424
</p>
423425

424426
<p><!-- CL 301709 -->
425-
TODO: <a href="https://golang.org/cl/301709">https://golang.org/cl/301709</a>: make go resolver aware of network parameter
427+
The Go DNS resolver now only sends one DNS query when resolving an address for an IPv4-only or IPv6-only network,
428+
rather than querying for both address families.
426429
</p>
427430

428431
<p><!-- CL 307030 -->
429-
TODO: <a href="https://golang.org/cl/307030">https://golang.org/cl/307030</a>: make ErrClosed and ParseError implement net.Error
432+
The <a href="/pkg/net/#ErrClosed"><code>ErrClosed</code></a> sentinel error and
433+
<a href="/pkg/net/#ParseError"><code>ParseError</code></a> error type now implement
434+
the <a href="/pkg/net/#Error"><code>net.Error</code></a> interface.
430435
</p>
431436
</dd>
432437
</dl><!-- net -->
@@ -441,7 +446,9 @@ <h3 id="minor_library_changes">Minor changes to the library</h3>
441446
</p>
442447

443448
<p><!-- CL 235437 -->
444-
TODO: <a href="https://golang.org/cl/235437">https://golang.org/cl/235437</a>: add to deadlines only when positive
449+
Setting the <a href="/pkg/net/http/#Server"><code>Server</code></a>
450+
<code>ReadTimeout</code> or <code>WriteTimeout</code> fields to a negative value now indicates no timeout
451+
rather than an immediate timeout.
445452
</p>
446453

447454
<p><!-- CL 308952 -->
@@ -454,15 +461,19 @@ <h3 id="minor_library_changes">Minor changes to the library</h3>
454461
<dl id="net/http/httptest"><dt><a href="/pkg/net/http/httptest/">net/http/httptest</a></dt>
455462
<dd>
456463
<p><!-- CL 308950 -->
457-
TODO: <a href="https://golang.org/cl/308950">https://golang.org/cl/308950</a>: panic on non-3 digit (XXX) status code in Recorder.WriteHeader
464+
<a href="/pkg/net/http/httptest/#ResponseRecorder.WriteHeader"><code>ResponseRecorder.WriteHeader></code></a>
465+
now panics when the provided code is not a valid three-digit HTTP status code.
466+
This matches the behavior of <a href="/pkg/net/http/#ResponseWriter"><code>ResponseWriter></code></a>
467+
implementations in the <a href="/pkg/net/http/"><code>net/http</code></a> package.
458468
</p>
459469
</dd>
460470
</dl><!-- net/http/httptest -->
461471

462472
<dl id="net/url"><dt><a href="/pkg/net/url/">net/url</a></dt>
463473
<dd>
464474
<p><!-- CL 314850 -->
465-
TODO: <a href="https://golang.org/cl/314850">https://golang.org/cl/314850</a>: add Values.Has
475+
The new method <a href="/pkg/net/url/#Values.Has"><code>Values.Has</code></a>
476+
reports whether a query parameter is set.
466477
</p>
467478
</dd>
468479
</dl><!-- net/url -->

src/os/pipe_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ func TestFdReadRace(t *testing.T) {
462462
// Give the other goroutine a chance to enter the Read.
463463
// It doesn't matter if this occasionally fails, the test
464464
// will still pass, it just won't test anything.
465-
time.Sleep(10 * time.Millisecond)
465+
//time.Sleep(10 * time.Millisecond)
466466
r.Fd()
467467

468468
// The bug was that Fd would hang until Read timed out.

0 commit comments

Comments
 (0)