Skip to content

Commit 911a5fd

Browse files
martischbradfitz
authored andcommitted
crypto/x509: skip TestSystemRoots
cgo and non-cgo code paths can disagree on the number of root certificates: === RUN TestSystemRoots --- FAIL: TestSystemRoots (0.31s) root_darwin_test.go:31: cgo sys roots: 93.605184ms root_darwin_test.go:32: non-cgo sys roots: 213.998586ms root_darwin_test.go:44: got 168 roots root_darwin_test.go:44: got 427 roots root_darwin_test.go:73: insufficient overlap between cgo and non-cgo roots; want at least 213, have 168 FAIL exit status 1 Updates #21416 Updates #24652 Change-Id: Idb6d35b17c142dfff79a10cf6b40a42d12f9d17e Reviewed-on: https://go-review.googlesource.com/125259 Run-TryBot: Martin Möhrmann <moehrmann@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
1 parent b39fb9e commit 911a5fd

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/crypto/x509/root_darwin_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ func TestSystemRoots(t *testing.T) {
1616
t.Skipf("skipping on %s/%s, no system root", runtime.GOOS, runtime.GOARCH)
1717
}
1818

19+
switch runtime.GOOS {
20+
case "darwin":
21+
t.Skipf("skipping on %s/%s until golang.org/issue/24652 has been resolved.", runtime.GOOS, runtime.GOARCH)
22+
}
23+
1924
t0 := time.Now()
2025
sysRoots := systemRootsPool() // actual system roots
2126
sysRootsDuration := time.Since(t0)

0 commit comments

Comments
 (0)