Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: add package debug/goobj #20105

Closed
josharian opened this issue Apr 25, 2017 · 3 comments
Closed

proposal: add package debug/goobj #20105

josharian opened this issue Apr 25, 2017 · 3 comments

Comments

@josharian
Copy link
Contributor

We have code scattered around that knows about the insides of cmd/compile's object files, in the compiler, the go/types importer, the linker, and some packages in x/tools. It'd be nice to consolidate this knowledge a bit, because the object files are non-trivial and they change over time, and the versioning support is non-trivial.

It's unfortunate to add API surface area in the main repo, but it seems like the natural place for it. Most of the shared implementation for the toolchain and go/types could be in an internal package, with minimal API exposed at debug/goobj as strictly needed for external tools. See CL 41053 for one such use.

This proposal obviously needs fleshing out, but I want to get an initial pulse before putting in much effort on the design.

cc @griesemer

@gopherbot gopherbot added this to the Proposal milestone Apr 25, 2017
@josharian
Copy link
Contributor Author

On reflection, probably the right solution here is #14386.

@rsc
Copy link
Contributor

rsc commented May 15, 2017

Yes, I'd like to avoid debug/goobj in the standard library. The one we use for cmd is internal for a reason.

@rsc
Copy link
Contributor

rsc commented May 15, 2017

Let's leave things as they are for now until we've cleaned up the object format (which is not a high priority right now - nothing is slowing us down significantly).

@rsc rsc closed this as completed May 15, 2017
@golang golang locked and limited conversation to collaborators May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants