-
Notifications
You must be signed in to change notification settings - Fork 18k
x/net/netlink, vendor/golang.org/x/net/netlink: new package #20637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What in the the standard library needs it? /cc @mdlayher |
As far as I can tell, the net package of standard library requires at least a) fetching netlink routing information base, b) parsing netlink routing messages related to on-link adjacencies for now. |
What bug is that? Which existing functions/methods don't work? Got a sample program? |
In other words, this proposal is a solution but you haven't yet sufficiently identified any problem. We don't accept proposals if there's not a problem. |
I've got a netlink package that does its best to just focus on pure netlink: not conflating it with rtnetlink, genetlink, etc. I would be happy to contribute parts or all of it to become That being said, because of #10565, I don't have an easy way of configuring timeouts without doing all of the epoll work myself. This isn't such a big deal because netlink is Linux only, but I'd be happy to see that issue solved for the sake of other sockets packages which may attempt to provide some cross platform functionality. [2] As for the original point, I think it could make sense to provide a high quality netlink package in x/net that could be useful both inside and outside the standard library. The biggest potential problem I can think of with the existing netlink functionality in I'm happy to help make this happen if there is a consensus that this proposal should move forward. [1] https://github.com/mdlayher/netlink |
More info on my concurrency woes with netlink and Go: http://lists.infradead.org/pipermail/libnl/2017-February/002293.html |
One more thing worth noting: I haven't seen any concurrency problems with the netlink usage in the standard library. I can't say for sure if it could be an issue or not. Perhaps @mikioh has other problems in mind? |
Could somebody please succinctly state the problem? |
Would love to hear if you had any specific pain points in mind, @mikioh . |
Having x/net/netlink seems fine. Vendoring it into stdlib seems less fine: x/net grows faster than most of the stnadard library, and I'd rather not give that growth a route into the stdlib. What specifically needs fixing in the standard library? |
Accepted for x/net/netlink (only). |
I propose to have a x/net/netlink package and vendor it to the standard library for maintenance purposes.
Netlink is a Linux-specific service for manipulating networking facilities inside the kernel. Fortunately, unlike routing messages and sockets on BSD variants, it doesn't have much ABI incompatibility between major kernel releases, but its complexity like TLV-in-AVP-in-TLV data representation could be a root cause of issues like #18714, #16681. So I think it's better to have and maintain a small separated package like the existing x/net/route package.
The exposed API would be like the following:
Thoughts?
The text was updated successfully, but these errors were encountered: