Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: permit iota, omission of init expressions in var declarations #21473

Open
griesemer opened this issue Aug 16, 2017 · 12 comments
Open
Labels
LanguageChange Suggested changes to the Go language LanguageChangeReview Discussed by language change review committee Proposal
Milestone

Comments

@griesemer
Copy link
Contributor

griesemer commented Aug 16, 2017

This was discussed very early in the language design, at the same time when we also introduced iota for constant declarations: Permit iota and the omission of initialization expressions not only in constant but also variable declarations. For instance, this would permit code like:

var (
    mercury = NewPlanet(iota + 1)
    venus
    earth
    mars
    ...
)

If my memory serves me right, we didn't pursue it at the time because there was no compelling or urgent argument in favor of it.

Such a mechanism could simplify the construction of related named objects and open the door to "enum" values that are not restricted to constant values and their respective types.

As such it may be a more elementary building block towards more complex "enums" in Go (see also the discussion in #19814).

Implementation:

  • Straight-forward changes would be required in the front-end of the compiler.

Language:

  • This would be a fully backward-compatible language change.
  • The change is fully orthogonal to existing features and would make variable and constant declarations more symmetric (and thus the language simpler).
  • No new concepts are introduced as this is essentially syntactic sugar.
@griesemer griesemer added v2 An incompatible library change LanguageChange Suggested changes to the Go language Proposal labels Aug 16, 2017
@gopherbot gopherbot added this to the Proposal milestone Aug 16, 2017
@cznic
Copy link
Contributor

cznic commented Aug 16, 2017

Language:

  • This would be a fully backward-compatible language change.

Seems problematic to me: https://play.golang.org/p/c0BE0M_WYI

@mvdan
Copy link
Member

mvdan commented Aug 16, 2017

@cznic how so? iota is a predeclared identifier, and you're replacing it with a constant. iota wouldn't work in that case with constants, either: https://play.golang.org/p/d2TVAZ1AU9

@cznic
Copy link
Contributor

cznic commented Aug 16, 2017

I know it's the same as with constant, it's just now double the surface. So questions also like "Why do my var-enums not work?" will be coming. I don't think adding the feature is worth complicating the language.
(A tiny addition to the complexity, sure, but non zero and they sum up.)

@griesemer
Copy link
Contributor Author

@cznic It's arguably less complexity in the language because now the same syntax and mechanism can be used for constants and variables. The question you're afraid might be coming up would have surfaced already now as it's quite common to have sequences of grouped constant declarations. iota is special in the language, like true and false, etc. You're in hot waters if you redeclare predeclared constants.

Unrelated: The reason I brought this issue up in the first place is that it might be another stepping stone towards addressing the desire for "enums" by some. Making it easier to declare groups of variables, perhaps together with a mechanism to enumerate over them might be a more Go-like approach than the the more heavy-weight enum support that is found in other languages.

@jimmyfrasche
Copy link
Member

This would be useful for stuff like type Exported { unexported int } where you want the identity but to hide the "numberness" of the value from the outside world

@rogpeppe
Copy link
Contributor

The main problem I have with this is that these are indeed variables, not constants, with the associated possibility of modification, and the lack of possibility for optimisation. That's a whole other can of worms though, of course.

@jimmyfrasche
Copy link
Member

@rogpeppe that's valid but the orthogonal concept of creating immutable values could handle that.

@faiface
Copy link

faiface commented Aug 18, 2017

Wouldn't this be unnecessary if we allowed non-{string, numeric} constants?

@ianlancetaylor
Copy link
Contributor

@faiface Probably, but that is not a simple change.

@ianlancetaylor ianlancetaylor added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Mar 13, 2018
@jimmyfrasche
Copy link
Member

type foo struct {
  n int
  s string
}
var (
  a = foo{n: iota, s: "a"}
  b = foo{s: "b"}
)

Does b.n == 1? It seems like that's what one would want but also that that's not how it would work.

@griesemer
Copy link
Contributor Author

@jimmyfrasche b.n would be zero, of course. The initialization expression for b is present, so it is used. There's no iota in there.

@gopherbot gopherbot removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Aug 16, 2019
@gopherbot gopherbot added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Sep 3, 2019
@mdempsky
Copy link
Contributor

This would be a fully backward-compatible language change.

Technically not fully. This code would now fail to compile: https://play.golang.org/p/GIz4UoSAKrD (Today the -iota expression evaluates to 0; but this proposal would change it to -1, which isn't representable as uint.)

But I think it's reasonable to assume no one writes obscure code like that except me when I'm coming up with contrived language spec test cases (e.g., #15550).

@ianlancetaylor ianlancetaylor removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Aug 23, 2023
@ianlancetaylor ianlancetaylor added LanguageChangeReview Discussed by language change review committee and removed v2 An incompatible library change labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LanguageChange Suggested changes to the Go language LanguageChangeReview Discussed by language change review committee Proposal
Projects
None yet
Development

No branches or pull requests

9 participants