Skip to content

runtime: sigprof handler crashes backtracing runtime.nanotime [1.10 backport] #24931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
heschi opened this issue Apr 18, 2018 · 6 comments
Closed

runtime: sigprof handler crashes backtracing runtime.nanotime [1.10 backport] #24931

heschi opened this issue Apr 18, 2018 · 6 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge

Comments

@heschi
Copy link
Contributor

heschi commented Apr 18, 2018

Original issue: #24925. It should be backported because it risks causing an unavoidable crash when CPU profiling is running.
@heschi heschi added the CherryPickCandidate Used during the release process for point releases label Apr 18, 2018
@heschi heschi added this to the Go1.10.2 milestone Apr 18, 2018
@andybons
Copy link
Member

+1

@ianlancetaylor?

@ianlancetaylor
Copy link
Contributor

OK for backport.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/107875 mentions this issue: [release-branch.go1.10] runtime: use saved state in SIGPROF handler for vDSO calls

@andybons andybons added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Apr 18, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/107955 mentions this issue: [release-branch.go1.10] runtime: get traceback from VDSO code

@heschi
Copy link
Contributor Author

heschi commented Apr 26, 2018

We changed our minds, so I'll abandon the CLs. There's no CherryPickRejected label; should I just close the issue?

@andybons
Copy link
Member

Yep just close it.

@andybons andybons removed this from the Go1.10.2 milestone Apr 27, 2018
@golang golang locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andybons @ianlancetaylor @gopherbot @heschi