Skip to content

x/vgo: implement modfetch/svnrepo #25075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rsc opened this issue Apr 25, 2018 · 2 comments
Closed

x/vgo: implement modfetch/svnrepo #25075

rsc opened this issue Apr 25, 2018 · 2 comments
Milestone

Comments

@rsc
Copy link
Contributor

rsc commented Apr 25, 2018

Added modfetch/gitrepo. Now we need modfetch/svnrepo too.
(See also #25074.)

@rsc rsc added this to the vgo milestone Apr 25, 2018
@rsc
Copy link
Contributor Author

rsc commented Apr 25, 2018

Notes from a few weeks ago below, using svn.apache.org/repos/asf/subversion as an example.

func (r *repo) Tags(prefix string) ([]string, error) {
	svn list https://svn.apache.org/repos/asf/subversion/tags (tags instead of trunk)
}

func (r *repo) Stat(rev string) (*codehost.RevInfo, error) {
	svn log -l 1 --xml remote
}

func (r *repo) ReadFile(rev, file string, maxSize int64) ([]byte, error) {
	svn cat remote+file@rev
}

func (r *repo) ReadZip(rev, file string, maxSize int64) (zip io.ReadCloser, actualSubdir string, err error) {
	svn export -r rev remote+file tmpdir
	build zip file
}

func (r *repo) LatestAt(t time.Time, branch string) ([]byte, error) {
	svn log -l 1 -r {DATE} remote (sub trunk for branch?)
	svn log -l1 -r '{2018-01-01T00:00:00Z}' https://svn.apache.org/repos/asf/subversion/trunk
	why does this not work?
}

@rsc
Copy link
Contributor Author

rsc commented Jul 6, 2018

All that remains is #26092.

@rsc rsc closed this as completed Jul 6, 2018
@golang golang locked and limited conversation to collaborators Jul 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants