plugin: crash when using ...interface{} as func args #25118

edwardhey · 2018-04-27T02:19:01Z

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (`go version`)?

1.10.1

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (`go env`)?

GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/edwardhey/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/opt/local/go:/mnt/xvdb/Projects/go"
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/fp/ltwplqgs0l1c4__5xwdht6140000gn/T/go-build179252213=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

plugin.go

package main

import (
	"fmt"
	"runtime"
)

type A struct {
}

func Main(args ...interface{}) {
	fmt.Println("[plugin] NumGoroutine:", runtime.NumGoroutine(), args)
}

build plugin

go build -buildmode=plugin ./plugin.go

main.go

package main

import (
	"plugin"
	"time"
)

func main() {
	p, err := plugin.Open("./plugin.so")
	if err != nil {
		panic(err)
	}
	sym, err := p.Lookup("Main")
	if err != nil {
		panic(err)
	}
	f := sym.(func(...interface{}))

	// Note that swapping these two lines makes the issue disappear
	go f(1)
	f(2)

	time.Sleep(time.Second)
}

run main.go

go run main.go

What did you expect to see?

[plugin] NumGoroutine: 2 [1]
[plugin] NumGoroutine: 2 [2]

What did you see instead?

[plugin] NumGoroutine: 2 [2]
runtime: bad pointer in frame plugin/unnamed-1af2f9e49ce9f7a74cfd724838e79534ecb20b50.Main at 0xc420050f78: 0x1
fatal error: invalid pointer found on stack

runtime stack:
runtime.throw(0x45e7148, 0x1e)
	/usr/local/go/src/runtime/panic.go:616 +0x81 fp=0x700003fae708 sp=0x700003fae6e8 pc=0x4527c51
runtime.adjustpointers(0xc420050f78, 0x700003fae800, 0x700003faebc0, 0x4656eb8, 0x465de80)
	/usr/local/go/src/runtime/stack.go:592 +0x23e fp=0x700003fae778 sp=0x700003fae708 pc=0x453b52e
runtime.adjustframe(0x700003faead0, 0x700003faebc0, 0x465de80)
	/usr/local/go/src/runtime/stack.go:663 +0x325 fp=0x700003fae830 sp=0x700003fae778 pc=0x453b875
runtime.gentraceback(0xffffffffffffffff, 0xffffffffffffffff, 0x0, 0xc420076780, 0x0, 0x0, 0x7fffffff, 0x45ea280, 0x700003faebc0, 0x0, ...)
	/usr/local/go/src/runtime/traceback.go:310 +0x12d3 fp=0x700003faeb38 sp=0x700003fae830 pc=0x4544533
runtime.copystack(0xc420076780, 0x1000, 0x700003faed01)
	/usr/local/go/src/runtime/stack.go:891 +0x26e fp=0x700003faecf0 sp=0x700003faeb38 pc=0x453c35e
runtime.newstack()
	/usr/local/go/src/runtime/stack.go:1063 +0x310 fp=0x700003faee80 sp=0x700003faecf0 pc=0x453c770
runtime.morestack()
	/usr/local/go/src/runtime/asm_amd64.s:480 +0x89 fp=0x700003faee88 sp=0x700003faee80 pc=0x454a3e9

goroutine 19 [copystack]:
runtime.(*mspan).nextFreeIndex(0x40b9ee0, 0x0)
	/usr/local/go/src/runtime/mbitmap.go:216 +0x16f fp=0xc420050b40 sp=0xc420050b38 pc=0x4510abf
runtime.(*mcache).nextFree(0x4116d90, 0x7, 0x0, 0x0, 0x0)
	/usr/local/go/src/runtime/malloc.go:548 +0x55 fp=0xc420050b98 sp=0xc420050b40 pc=0x450ea95
runtime.mallocgc(0x20, 0x0, 0x0, 0x0)
	/usr/local/go/src/runtime/malloc.go:710 +0x7e5 fp=0xc420050c38 sp=0xc420050b98 pc=0x450f485
runtime.growslice(0x4063260, 0x0, 0x0, 0x0, 0x16, 0x411c140, 0x0, 0x0)
	/usr/local/go/src/runtime/slice.go:172 +0x221 fp=0xc420050ca0 sp=0xc420050c38 pc=0x453a211
fmt.(*buffer).WriteString(...)
	/usr/local/go/src/fmt/print.go:82
fmt.(*fmt).padString(0xc4200d2040, 0x45e58fb, 0x16)
	/usr/local/go/src/fmt/format.go:110 +0x10b fp=0xc420050d28 sp=0xc420050ca0 pc=0x459f68b
fmt.(*fmt).fmt_s(0xc4200d2040, 0x45e58fb, 0x16)
	/usr/local/go/src/fmt/format.go:328 +0x61 fp=0xc420050d60 sp=0xc420050d28 pc=0x45a03c1
fmt.(*pp).fmtString(0xc4200d2000, 0x45e58fb, 0x16, 0xc400000076)
	/usr/local/go/src/fmt/print.go:437 +0x11f fp=0xc420050d98 sp=0xc420050d60 pc=0x45a361f
fmt.(*pp).printArg(0xc4200d2000, 0x4063120, 0x45f66b0, 0x76)
	/usr/local/go/src/fmt/print.go:671 +0x795 fp=0xc420050e10 sp=0xc420050d98 pc=0x45a55c5
fmt.(*pp).doPrintln(0xc4200d2000, 0xc420050f88, 0x3, 0x3)
	/usr/local/go/src/fmt/print.go:1146 +0x45 fp=0xc420050e80 sp=0xc420050e10 pc=0x45a7ff5
fmt.Fprintln(0x45f6da0, 0xc4200a4ea8, 0xc42003ef88, 0x3, 0x3, 0x4060060, 0x4505e01, 0xc4200d0000)
	/usr/local/go/src/fmt/print.go:254 +0x58 fp=0xc420050ee8 sp=0xc420050e80 pc=0x45a20c8
fmt.Println(0xc42003ef88, 0x3, 0x3, 0xc4200d0000, 0x0, 0x0)
	/usr/local/go/src/fmt/print.go:264 +0x5a fp=0xc420050f38 sp=0xc420050ee8 pc=0x45a21ca
plugin/unnamed-1af2f9e49ce9f7a74cfd724838e79534ecb20b50.Main(0xc420094200, 0x1, 0x1)
	/tmp/test/plugin.go:12 +0x10a fp=0xc420050fc8 sp=0xc420050f38 pc=0x45a856a
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:2361 +0x1 fp=0xc420050fd0 sp=0xc420050fc8 pc=0x404c791
created by main.main
	/tmp/test/main.go:20 +0x128

goroutine 1 [sleep]:
runtime.gopark(0x407c488, 0x40bc980, 0x40774ad, 0x5, 0x13, 0x2)
	/usr/local/go/src/runtime/proc.go:291 +0x11a fp=0xc420065e60 sp=0xc420065e40 pc=0x402873a
runtime.goparkunlock(0x40bc980, 0x40774ad, 0x5, 0x13, 0x2)
	/usr/local/go/src/runtime/proc.go:297 +0x5e fp=0xc420065ea0 sp=0xc420065e60 pc=0x40287ee
time.Sleep(0x3b9aca00)
	/usr/local/go/src/runtime/time.go:102 +0x166 fp=0xc420065f00 sp=0xc420065ea0 pc=0x403f276
main.main()
	/tmp/test/main.go:23 +0x18d fp=0xc420065f88 sp=0xc420065f00 pc=0x4055bdd
runtime.main()
	/usr/local/go/src/runtime/proc.go:198 +0x212 fp=0xc420065fe0 sp=0xc420065f88 pc=0x40282f2
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:2361 +0x1 fp=0xc420065fe8 sp=0xc420065fe0 pc=0x404c791

goroutine 2 [force gc (idle)]:
runtime.gopark(0x407c488, 0x40b9d60, 0x4078014, 0xf, 0x407c314, 0x1)
	/usr/local/go/src/runtime/proc.go:291 +0x11a fp=0xc420042768 sp=0xc420042748 pc=0x402873a
runtime.goparkunlock(0x40b9d60, 0x4078014, 0xf, 0x14, 0x1)
	/usr/local/go/src/runtime/proc.go:297 +0x5e fp=0xc4200427a8 sp=0xc420042768 pc=0x40287ee
runtime.forcegchelper()
	/usr/local/go/src/runtime/proc.go:248 +0xcc fp=0xc4200427e0 sp=0xc4200427a8 pc=0x402857c
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:2361 +0x1 fp=0xc4200427e8 sp=0xc4200427e0 pc=0x404c791
created by runtime.init.4
	/usr/local/go/src/runtime/proc.go:237 +0x35

goroutine 3 [GC sweep wait]:
runtime.gopark(0x407c488, 0x40b9e40, 0x4077d1f, 0xd, 0x401c114, 0x1)
	/usr/local/go/src/runtime/proc.go:291 +0x11a fp=0xc420042f60 sp=0xc420042f40 pc=0x402873a
runtime.goparkunlock(0x40b9e40, 0x4077d1f, 0xd, 0x14, 0x1)
	/usr/local/go/src/runtime/proc.go:297 +0x5e fp=0xc420042fa0 sp=0xc420042f60 pc=0x40287ee
runtime.bgsweep(0xc420070000)
	/usr/local/go/src/runtime/mgcsweep.go:52 +0xa3 fp=0xc420042fd8 sp=0xc420042fa0 pc=0x401c1a3
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:2361 +0x1 fp=0xc420042fe0 sp=0xc420042fd8 pc=0x404c791
created by runtime.gcenable
	/usr/local/go/src/runtime/mgc.go:216 +0x58

goroutine 18 [finalizer wait]:
runtime.gopark(0x45ea488, 0x40d5fd8, 0x45e4431, 0xe, 0x14, 0x1)
	/usr/local/go/src/runtime/proc.go:291 +0x126 fp=0xc42003e718 sp=0xc42003e6f8 pc=0x45295e6
runtime.goparkunlock(0x40d5fd8, 0x45e4431, 0xe, 0x14, 0x1)
	/usr/local/go/src/runtime/proc.go:297 +0x5e fp=0xc42003e758 sp=0xc42003e718 pc=0x452969e
runtime.runfinq()
	/usr/local/go/src/runtime/mfinal.go:175 +0xbe fp=0xc42003e7e0 sp=0xc42003e758 pc=0x4513fde
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:2361 +0x1 fp=0xc42003e7e8 sp=0xc42003e7e0 pc=0x454c841
created by runtime.createfing
	/usr/local/go/src/runtime/mfinal.go:156 +0x66

goroutine 20 [syscall]:
runtime.notetsleepg(0x40bc9a0, 0x3b9aa84e, 0x0)
	/usr/local/go/src/runtime/lock_sema.go:280 +0x4b fp=0xc42003f760 sp=0xc42003f720 pc=0x400e85b
runtime.timerproc(0x40bc980)
	/usr/local/go/src/runtime/time.go:261 +0x2e7 fp=0xc42003f7d8 sp=0xc42003f760 pc=0x403f867
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:2361 +0x1 fp=0xc42003f7e0 sp=0xc42003f7d8 pc=0x404c791
created by runtime.(*timersBucket).addtimerLocked
	/usr/local/go/src/runtime/time.go:160 +0x107
exit status 2

The text was updated successfully, but these errors were encountered:

randall77 · 2018-04-27T03:22:28Z

The signature of plugin.Main and the way you're calling it don't match.
(...interface[]) and (int) aren't the same.
This would work without a plugin because the compiler inserts the transformation for you.
In a plugin call, the compiler doesn't know to insert that transformation.

I'm kind of surprised that the line sym.(func(int)) succeeds. That's the bug, and it would be nice if the plugin package gave an error in this scenario. I don't know why it doesn't.

Use sym.(func(...interface{})) and everything should work.

randall77 · 2018-04-27T03:53:10Z

I'm kind of surprised that the line sym.(func(int)) succeeds.

I was right to be surprised. It doesn't succeed.

$ ~/go1.10/bin/go run main.go
panic: interface conversion: plugin.Symbol is func(...interface {}), not func(int)

goroutine 1 [running]:
main.main()
	/home/khr/gowork/issue25118/main.go:17 +0x1f9
exit status 2

What's different about what you're doing and what I did?
I'm on linux/amd64.
I think I followed your reproduction steps exactly.

edwardhey · 2018-04-27T03:59:19Z

Sorry about the signature of plugin.Main, I just posted the wrong code of main.go.
I use sym.(func(...interface{})) in main.go and crash again.

randall77 · 2018-04-27T04:04:55Z

Ok, that makes more sense.
I can reproduce on darwin/amd64.
I cannot reproduce on linux/amd64.
Not sure what is going on. Plugin folks?
@crawshaw @ianlancetaylor

agnivade · 2018-04-27T04:53:20Z

@randall77 - Feel free to change it to "NeedsFix" if you think so.

randall77 · 2018-04-27T05:15:03Z

It does appear fixed at tip.
Probably a dup of #23369?

agnivade · 2018-04-27T06:06:58Z

@edwardhey - Can you try with tip ?

edwardhey · 2018-04-27T06:38:34Z

#23369 ？I tried, crash too.

runtime: bad pointer in frame main.main at 0xc4200b1f70: 0x1
fatal error: invalid pointer found on stack

runtime stack:
runtime.throw(0x4563808, 0x1e)
	/usr/local/go/src/runtime/panic.go:616 +0x81 fp=0x7ffeefbfef70 sp=0x7ffeefbfef50 pc=0x451eb81
runtime.adjustpointers(0xc4200b1f70, 0x7ffeefbff068, 0x7ffeefbff428, 0x40b3ca0, 0x40b5a40)
	/usr/local/go/src/runtime/stack.go:592 +0x23e fp=0x7ffeefbfefe0 sp=0x7ffeefbfef70 pc=0x453136e
runtime.adjustframe(0x7ffeefbff338, 0x7ffeefbff428, 0x40b5a40)
	/usr/local/go/src/runtime/stack.go:663 +0x325 fp=0x7ffeefbff098 sp=0x7ffeefbfefe0 pc=0x45316b5
runtime.gentraceback(0xffffffffffffffff, 0xffffffffffffffff, 0x0, 0xc420000180, 0x0, 0x0, 0x7fffffff, 0x4565080, 0x7ffeefbff428, 0x0, ...)
	/usr/local/go/src/runtime/traceback.go:310 +0x12d3 fp=0x7ffeefbff3a0 sp=0x7ffeefbff098 pc=0x4537fa3
runtime.copystack(0xc420000180, 0x4000, 0x7ffeefbff501)
	/usr/local/go/src/runtime/stack.go:891 +0x26e fp=0x7ffeefbff558 sp=0x7ffeefbff3a0 pc=0x453219e
runtime.newstack()
	/usr/local/go/src/runtime/stack.go:1063 +0x310 fp=0x7ffeefbff6e8 sp=0x7ffeefbff558 pc=0x45325b0
runtime.morestack()
	/usr/local/go/src/runtime/asm_amd64.s:480 +0x89 fp=0x7ffeefbff6f0 sp=0x7ffeefbff6e8 pc=0x453d7e9

goroutine 1 [copystack]:
plugin/unnamed-45e3d7edcb80a6ab1b6f1054fb086d209809a205.F()
	/tmp/test/plugin.go:3 +0x63 fp=0xc4200b1f40 sp=0xc4200b1f38 pc=0x45446b3
main.main()
	/tmp/test/main.go:29 +0x7a fp=0xc4200b1f88 sp=0xc4200b1f40 pc=0x40549ea
runtime.main()
	/usr/local/go/src/runtime/proc.go:198 +0x212 fp=0xc4200b1fe0 sp=0xc4200b1f88 pc=0x4027fd2
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:2361 +0x1 fp=0xc4200b1fe8 sp=0xc4200b1fe0 pc=0x404ba01

goroutine 2 [force gc (idle)]:
runtime.gopark(0x407ac00, 0x40b7cb0, 0x4076871, 0xf, 0x407ab14, 0x1)
	/usr/local/go/src/runtime/proc.go:291 +0x11a fp=0xc420042768 sp=0xc420042748 pc=0x402841a
runtime.goparkunlock(0x40b7cb0, 0x4076871, 0xf, 0x14, 0x1)
	/usr/local/go/src/runtime/proc.go:297 +0x5e fp=0xc4200427a8 sp=0xc420042768 pc=0x40284ce
runtime.forcegchelper()
	/usr/local/go/src/runtime/proc.go:248 +0xcc fp=0xc4200427e0 sp=0xc4200427a8 pc=0x402825c
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:2361 +0x1 fp=0xc4200427e8 sp=0xc4200427e0 pc=0x404ba01
created by runtime.init.4
	/usr/local/go/src/runtime/proc.go:237 +0x35

goroutine 3 [GC sweep wait]:
runtime.gopark(0x407ac00, 0x40b7da0, 0x407657c, 0xd, 0x401be14, 0x1)
	/usr/local/go/src/runtime/proc.go:291 +0x11a fp=0xc420042f60 sp=0xc420042f40 pc=0x402841a
runtime.goparkunlock(0x40b7da0, 0x407657c, 0xd, 0x14, 0x1)
	/usr/local/go/src/runtime/proc.go:297 +0x5e fp=0xc420042fa0 sp=0xc420042f60 pc=0x40284ce
runtime.bgsweep(0xc420070000)
	/usr/local/go/src/runtime/mgcsweep.go:52 +0xa3 fp=0xc420042fd8 sp=0xc420042fa0 pc=0x401be83
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:2361 +0x1 fp=0xc420042fe0 sp=0xc420042fd8 pc=0x404ba01
created by runtime.gcenable
	/usr/local/go/src/runtime/mgc.go:216 +0x58
exit status 2

cherrymui · 2018-05-04T17:51:07Z

@edwardhey no, not try to reproduce #23369. Try your test case with Go tip (not 1.10.1). It works for me locally.

edwardhey · 2018-05-29T06:59:21Z

@cherrymui I tried with 1.10.2, still crash.

ianlancetaylor · 2018-06-27T18:42:17Z

@edwardhey Can you try with the 1.11beta1 release? Thanks.

fatedier · 2018-07-03T09:23:31Z

@ianlancetaylor It works fine with 1.11beta1 release in my darwin/amd64 os, that will panic with 1.10.2 and 1.10.3.

ianlancetaylor · 2018-07-03T12:55:54Z

Thanks, closing.

randall77 · 2018-07-03T16:33:55Z

I've started the backport of the fix to 1.9 and 1.10 on #26202 and #26203 .

agnivade changed the title ~~go plugin crash when using ...interface{} as func args~~ plugin: crash when using ...interface{} as func args Apr 27, 2018

agnivade added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 27, 2018

agnivade added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Apr 27, 2018

agnivade removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Apr 27, 2018

bcmills added this to the Go1.11 milestone Apr 27, 2018

MakMukhi mentioned this issue May 7, 2018

got an error when try to start grpc server in shared library grpc/grpc-go#2052

Closed

randall77 added the release-blocker label May 8, 2018

ianlancetaylor closed this as completed Jul 3, 2018

golang locked and limited conversation to collaborators Jul 3, 2019

gopherbot added the FrozenDueToAge label Jul 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

plugin: crash when using ...interface{} as func args #25118

plugin: crash when using ...interface{} as func args #25118

edwardhey commented Apr 27, 2018 •

edited

Loading

randall77 commented Apr 27, 2018

randall77 commented Apr 27, 2018

edwardhey commented Apr 27, 2018

randall77 commented Apr 27, 2018

agnivade commented Apr 27, 2018

randall77 commented Apr 27, 2018

agnivade commented Apr 27, 2018

edwardhey commented Apr 27, 2018

cherrymui commented May 4, 2018

edwardhey commented May 29, 2018

ianlancetaylor commented Jun 27, 2018

fatedier commented Jul 3, 2018

ianlancetaylor commented Jul 3, 2018

randall77 commented Jul 3, 2018

plugin: crash when using ...interface{} as func args #25118

plugin: crash when using ...interface{} as func args #25118

Comments

edwardhey commented Apr 27, 2018 • edited Loading

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

randall77 commented Apr 27, 2018

randall77 commented Apr 27, 2018

edwardhey commented Apr 27, 2018

randall77 commented Apr 27, 2018

agnivade commented Apr 27, 2018

randall77 commented Apr 27, 2018

agnivade commented Apr 27, 2018

edwardhey commented Apr 27, 2018

cherrymui commented May 4, 2018

edwardhey commented May 29, 2018

ianlancetaylor commented Jun 27, 2018

fatedier commented Jul 3, 2018

ianlancetaylor commented Jul 3, 2018

randall77 commented Jul 3, 2018

edwardhey commented Apr 27, 2018 •

edited

Loading

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?