Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: provide unambiguous link to CL #28839

Closed
josharian opened this issue Nov 16, 2018 · 3 comments
Closed

x/build/cmd/gerritbot: provide unambiguous link to CL #28839

josharian opened this issue Nov 16, 2018 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@josharian
Copy link
Contributor

golang.org/cl/NNN disambiguation just broke. #28836 suggests an disambiguation page, which is a fine idea. But when gopherbot is posting links to issues, there's no ambiguity. Let's find some way for gopherbot to provide a direct link.

Maybe it's a new golang.org/gerrit/NNN link? Or gopherbot posting markdown?

cc @dmitshur @bradfitz @andybons @adg
@gopherbot gopherbot added this to the Unreleased milestone Nov 16, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 16, 2018
@josharian josharian added help wanted NeedsFix The path to resolution is known, but the work has not been done. and removed Builders x/build issues (builders, bots, dashboards) labels Nov 16, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 16, 2018
@josharian josharian mentioned this issue Nov 16, 2018
Closed
@josharian josharian added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsFix The path to resolution is known, but the work has not been done. labels Nov 16, 2018
@andybons andybons self-assigned this Nov 18, 2018
@andybons andybons changed the title x/build/cmd/gopherbot: provide unambiguous link to CL x/build/cmd/gerritbot: provide unambiguous link to CL Nov 26, 2018
@andybons
Copy link
Member

Given that #28836 has been fixed and the links point to the right Gerrit changes, I'm not sure this is worth the work.

Feel free to re-open if you feel strongly otherwise.

@josharian
Copy link
Contributor Author

Is #28836 fixed permanently or just until we hit another threshold?

@bradfitz
Copy link
Contributor

The commit message and code describes it at length so to be brief here on phone I'll just say permanently.

@golang golang locked and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @josharian @andybons @gopherbot